[PATCH net] eth: fbnic: Increase FBNIC_QUEUE_SIZE_MIN to 64

[PATCH net] eth: fbnic: Increase FBNIC_QUEUE_SIZE_MIN to 64

[Dimitri Daskalakis]

From: Dimitri Daskalakis <daskald@meta.com>

On systems with 64K pages, RX queues will be wedged if users set the
descriptor count to the current minimum (16). Fbnic fragments large
pages into 4K chunks, and scales down the ring size accordingly. With
64K pages and 16 descriptors, the ring size mask is 0 and will never
be filled.

32 descriptors is another special case that wedges the RX rings.
Internally, the rings track pages for the head/tail pointers, not page
fragments. So with 32 descriptors, there's only 1 usable page as one
ring slot is kept empty to disambiguate between an empty/full ring.
As a result, the head pointer never advances and the HW stalls after
consuming 16 page fragments.

Fixes: 0cb4c0a13723 ("eth: fbnic: Implement Rx queue alloc/start/stop/free")
Signed-off-by: Dimitri Daskalakis <daskald@meta.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
 drivers/net/ethernet/meta/fbnic/fbnic_txrx.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/meta/fbnic/fbnic_txrx.h b/drivers/net/ethernet/meta/fbnic/fbnic_txrx.h
index 980965274079..e03c9d2c38dc 100644
--- a/drivers/net/ethernet/meta/fbnic/fbnic_txrx.h
+++ b/drivers/net/ethernet/meta/fbnic/fbnic_txrx.h
@@ -38,7 +38,7 @@ struct fbnic_net;
 #define FBNIC_MAX_XDPQS			128u
 
 /* These apply to TWQs, TCQ, RCQ */
-#define FBNIC_QUEUE_SIZE_MIN		16u
+#define FBNIC_QUEUE_SIZE_MIN		64u
 #define FBNIC_QUEUE_SIZE_MAX		SZ_64K
 
 #define FBNIC_TXQ_SIZE_DEFAULT		1024
-- 
2.52.0

Re: [PATCH net] eth: fbnic: Increase FBNIC_QUEUE_SIZE_MIN to 64

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Wed,  1 Apr 2026 09:28:48 -0700 you wrote:
> From: Dimitri Daskalakis <daskald@meta.com>
> 
> On systems with 64K pages, RX queues will be wedged if users set the
> descriptor count to the current minimum (16). Fbnic fragments large
> pages into 4K chunks, and scales down the ring size accordingly. With
> 64K pages and 16 descriptors, the ring size mask is 0 and will never
> be filled.
> 
> [...]

Here is the summary with links:
  - [net] eth: fbnic: Increase FBNIC_QUEUE_SIZE_MIN to 64
    https://git.kernel.org/netdev/net/c/ec7067e66119

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html