* [PATCH net-next] inet: remove leftover EXPORT_SYMBOL()
@ 2026-04-02 17:44 Eric Dumazet
2026-04-03 10:49 ` Fernando Fernandez Mancera
2026-04-03 23:10 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 4+ messages in thread
From: Eric Dumazet @ 2026-04-02 17:44 UTC (permalink / raw)
To: David S . Miller, Jakub Kicinski, Paolo Abeni
Cc: Simon Horman, Kuniyuki Iwashima, netdev, eric.dumazet,
Eric Dumazet
IPv6 is no longer a module, we no longer need to export these symbols.
Signed-off-by: Eric Dumazet <edumazet@google.com>
---
net/ipv4/icmp.c | 4 ----
net/ipv4/ipmr_base.c | 13 -------------
net/ipv4/udp_offload.c | 4 ----
3 files changed, 21 deletions(-)
diff --git a/net/ipv4/icmp.c b/net/ipv4/icmp.c
index fb397fbb28fc67f012d39398de5e9fdd1dd216bd..2f4fac22d1aba3d100c57a56b51efd57283430a5 100644
--- a/net/ipv4/icmp.c
+++ b/net/ipv4/icmp.c
@@ -263,7 +263,6 @@ bool icmp_global_allow(struct net *net)
}
return true;
}
-EXPORT_SYMBOL(icmp_global_allow);
void icmp_global_consume(struct net *net)
{
@@ -273,7 +272,6 @@ void icmp_global_consume(struct net *net)
if (credits)
atomic_sub(credits, &net->ipv4.icmp_global_credit);
}
-EXPORT_SYMBOL(icmp_global_consume);
static bool icmpv4_mask_allow(struct net *net, int type, int code)
{
@@ -1378,7 +1376,6 @@ bool icmp_build_probe(struct sk_buff *skb, struct icmphdr *icmphdr)
icmphdr->code = ICMP_EXT_CODE_MAL_QUERY;
return true;
}
-EXPORT_SYMBOL_GPL(icmp_build_probe);
/*
* Handle ICMP Timestamp requests.
@@ -1600,7 +1597,6 @@ void ip_icmp_error_rfc4884(const struct sk_buff *skb,
if (!ip_icmp_error_rfc4884_validate(skb, off))
out->flags |= SO_EE_RFC4884_FLAG_INVALID;
}
-EXPORT_SYMBOL_GPL(ip_icmp_error_rfc4884);
int icmp_err(struct sk_buff *skb, u32 info)
{
diff --git a/net/ipv4/ipmr_base.c b/net/ipv4/ipmr_base.c
index fd27f2ca69783bc04e76a42c0382b87a64069a07..37a3c144276c75d56d5d295a2c852f5ffd262f65 100644
--- a/net/ipv4/ipmr_base.c
+++ b/net/ipv4/ipmr_base.c
@@ -27,7 +27,6 @@ void vif_device_init(struct vif_device *v,
else
v->link = dev->ifindex;
}
-EXPORT_SYMBOL(vif_device_init);
struct mr_table *
mr_table_alloc(struct net *net, u32 id,
@@ -60,7 +59,6 @@ mr_table_alloc(struct net *net, u32 id,
table_set(mrt, net);
return mrt;
}
-EXPORT_SYMBOL(mr_table_alloc);
void *mr_mfc_find_parent(struct mr_table *mrt, void *hasharg, int parent)
{
@@ -74,7 +72,6 @@ void *mr_mfc_find_parent(struct mr_table *mrt, void *hasharg, int parent)
return NULL;
}
-EXPORT_SYMBOL(mr_mfc_find_parent);
void *mr_mfc_find_any_parent(struct mr_table *mrt, int vifi)
{
@@ -89,7 +86,6 @@ void *mr_mfc_find_any_parent(struct mr_table *mrt, int vifi)
return NULL;
}
-EXPORT_SYMBOL(mr_mfc_find_any_parent);
void *mr_mfc_find_any(struct mr_table *mrt, int vifi, void *hasharg)
{
@@ -109,7 +105,6 @@ void *mr_mfc_find_any(struct mr_table *mrt, int vifi, void *hasharg)
return mr_mfc_find_any_parent(mrt, vifi);
}
-EXPORT_SYMBOL(mr_mfc_find_any);
#ifdef CONFIG_PROC_FS
void *mr_vif_seq_idx(struct net *net, struct mr_vif_iter *iter, loff_t pos)
@@ -124,7 +119,6 @@ void *mr_vif_seq_idx(struct net *net, struct mr_vif_iter *iter, loff_t pos)
}
return NULL;
}
-EXPORT_SYMBOL(mr_vif_seq_idx);
void *mr_vif_seq_next(struct seq_file *seq, void *v, loff_t *pos)
{
@@ -143,7 +137,6 @@ void *mr_vif_seq_next(struct seq_file *seq, void *v, loff_t *pos)
}
return NULL;
}
-EXPORT_SYMBOL(mr_vif_seq_next);
void *mr_mfc_seq_idx(struct net *net,
struct mr_mfc_iter *it, loff_t pos)
@@ -168,7 +161,6 @@ void *mr_mfc_seq_idx(struct net *net,
it->cache = NULL;
return NULL;
}
-EXPORT_SYMBOL(mr_mfc_seq_idx);
void *mr_mfc_seq_next(struct seq_file *seq, void *v,
loff_t *pos)
@@ -203,7 +195,6 @@ void *mr_mfc_seq_next(struct seq_file *seq, void *v,
return NULL;
}
-EXPORT_SYMBOL(mr_mfc_seq_next);
#endif
int mr_fill_mroute(struct mr_table *mrt, struct sk_buff *skb,
@@ -275,7 +266,6 @@ int mr_fill_mroute(struct mr_table *mrt, struct sk_buff *skb,
rtm->rtm_type = RTN_MULTICAST;
return 1;
}
-EXPORT_SYMBOL(mr_fill_mroute);
static bool mr_mfc_uses_dev(const struct mr_table *mrt,
const struct mr_mfc *c,
@@ -347,7 +337,6 @@ int mr_table_dump(struct mr_table *mrt, struct sk_buff *skb,
cb->args[1] = e;
return err;
}
-EXPORT_SYMBOL(mr_table_dump);
int mr_rtm_dumproute(struct sk_buff *skb, struct netlink_callback *cb,
struct mr_table *(*iter)(struct net *net,
@@ -390,7 +379,6 @@ int mr_rtm_dumproute(struct sk_buff *skb, struct netlink_callback *cb,
return skb->len;
}
-EXPORT_SYMBOL(mr_rtm_dumproute);
int mr_dump(struct net *net, struct notifier_block *nb, unsigned short family,
int (*rules_dump)(struct net *net,
@@ -444,4 +432,3 @@ int mr_dump(struct net *net, struct notifier_block *nb, unsigned short family,
return 0;
}
-EXPORT_SYMBOL(mr_dump);
diff --git a/net/ipv4/udp_offload.c b/net/ipv4/udp_offload.c
index 98e92da726b5ec1ce2d12f8de2642f9c11f056a4..a0813d425b7162367866786f1f5d862d1efdcbf5 100644
--- a/net/ipv4/udp_offload.c
+++ b/net/ipv4/udp_offload.c
@@ -343,7 +343,6 @@ struct sk_buff *skb_udp_tunnel_segment(struct sk_buff *skb,
return segs;
}
-EXPORT_SYMBOL(skb_udp_tunnel_segment);
static void __udpv4_gso_segment_csum(struct sk_buff *seg,
__be32 *oldip, __be32 *newip,
@@ -635,7 +634,6 @@ struct sk_buff *__udp_gso_segment(struct sk_buff *gso_skb,
}
return segs;
}
-EXPORT_SYMBOL_GPL(__udp_gso_segment);
static struct sk_buff *udp4_ufo_fragment(struct sk_buff *skb,
netdev_features_t features)
@@ -852,7 +850,6 @@ struct sk_buff *udp_gro_receive(struct list_head *head, struct sk_buff *skb,
skb_gro_flush_final(skb, pp, flush);
return pp;
}
-EXPORT_SYMBOL(udp_gro_receive);
static struct sock *udp4_gro_lookup_skb(struct sk_buff *skb, __be16 sport,
__be16 dport)
@@ -957,7 +954,6 @@ int udp_gro_complete(struct sk_buff *skb, int nhoff,
return err;
}
-EXPORT_SYMBOL(udp_gro_complete);
INDIRECT_CALLABLE_SCOPE int udp4_gro_complete(struct sk_buff *skb, int nhoff)
{
--
2.53.0.1213.gd9a14994de-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] inet: remove leftover EXPORT_SYMBOL()
2026-04-02 17:44 [PATCH net-next] inet: remove leftover EXPORT_SYMBOL() Eric Dumazet
@ 2026-04-03 10:49 ` Fernando Fernandez Mancera
2026-04-03 10:59 ` Eric Dumazet
2026-04-03 23:10 ` patchwork-bot+netdevbpf
1 sibling, 1 reply; 4+ messages in thread
From: Fernando Fernandez Mancera @ 2026-04-03 10:49 UTC (permalink / raw)
To: Eric Dumazet, David S . Miller, Jakub Kicinski, Paolo Abeni
Cc: Simon Horman, Kuniyuki Iwashima, netdev, eric.dumazet
On 4/2/26 7:44 PM, Eric Dumazet wrote:
> IPv6 is no longer a module, we no longer need to export these symbols.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> ---
> net/ipv4/icmp.c | 4 ----
> net/ipv4/ipmr_base.c | 13 -------------
> net/ipv4/udp_offload.c | 4 ----
> 3 files changed, 21 deletions(-)
>
Thank you and sorry for missing this.
Reviewed-by: Fernando Fernandez Mancera <fmancera@suse.de>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] inet: remove leftover EXPORT_SYMBOL()
2026-04-03 10:49 ` Fernando Fernandez Mancera
@ 2026-04-03 10:59 ` Eric Dumazet
0 siblings, 0 replies; 4+ messages in thread
From: Eric Dumazet @ 2026-04-03 10:59 UTC (permalink / raw)
To: Fernando Fernandez Mancera
Cc: David S . Miller, Jakub Kicinski, Paolo Abeni, Simon Horman,
Kuniyuki Iwashima, netdev, eric.dumazet
On Fri, Apr 3, 2026 at 3:49 AM Fernando Fernandez Mancera
<fmancera@suse.de> wrote:
>
> On 4/2/26 7:44 PM, Eric Dumazet wrote:
> > IPv6 is no longer a module, we no longer need to export these symbols.
> >
> > Signed-off-by: Eric Dumazet <edumazet@google.com>
> > ---
> > net/ipv4/icmp.c | 4 ----
> > net/ipv4/ipmr_base.c | 13 -------------
> > net/ipv4/udp_offload.c | 4 ----
> > 3 files changed, 21 deletions(-)
> >
> Thank you and sorry for missing this.
>
> Reviewed-by: Fernando Fernandez Mancera <fmancera@suse.de>
No worries, these were not using EXPORT_IPV6_MOD[_GPL]() yet.
Thanks !
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] inet: remove leftover EXPORT_SYMBOL()
2026-04-02 17:44 [PATCH net-next] inet: remove leftover EXPORT_SYMBOL() Eric Dumazet
2026-04-03 10:49 ` Fernando Fernandez Mancera
@ 2026-04-03 23:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-04-03 23:10 UTC (permalink / raw)
To: Eric Dumazet; +Cc: davem, kuba, pabeni, horms, kuniyu, netdev, eric.dumazet
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Thu, 2 Apr 2026 17:44:30 +0000 you wrote:
> IPv6 is no longer a module, we no longer need to export these symbols.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> ---
> net/ipv4/icmp.c | 4 ----
> net/ipv4/ipmr_base.c | 13 -------------
> net/ipv4/udp_offload.c | 4 ----
> 3 files changed, 21 deletions(-)
Here is the summary with links:
- [net-next] inet: remove leftover EXPORT_SYMBOL()
https://git.kernel.org/netdev/net-next/c/1666d945b57b
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-04-03 23:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-02 17:44 [PATCH net-next] inet: remove leftover EXPORT_SYMBOL() Eric Dumazet
2026-04-03 10:49 ` Fernando Fernandez Mancera
2026-04-03 10:59 ` Eric Dumazet
2026-04-03 23:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox