[PATCH net-next] net: mctp: tests: use actual address when creating dev with addr

[PATCH net-next] net: mctp: tests: use actual address when creating dev with addr

[Jeremy Kerr]

Sashiko reports:

> This isn't a bug in the core networking code, but the addr parameter
> appears to be ignored here.

In mctp_test_create_dev_with_addr(), we are ignoring the addr argument
and just using `8`. Use the passed address instead.

All invocations use 8 anyway, so no effective change at present.

Fixes: 22cb45afd221 ("net: mctp: perform source address lookups when we populate our dst")
Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
---
 net/mctp/test/utils.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/mctp/test/utils.c b/net/mctp/test/utils.c
index 2f79f8c1a2b4..c3987d5ade7a 100644
--- a/net/mctp/test/utils.c
+++ b/net/mctp/test/utils.c
@@ -95,7 +95,7 @@ struct mctp_test_dev *mctp_test_create_dev_with_addr(mctp_eid_t addr)
 	}
 
 	dev->mdev->num_addrs = 1;
-	dev->mdev->addrs[0] = 8;
+	dev->mdev->addrs[0] = addr;
 
 	return dev;
 }

---
base-commit: 8b0e64d6c9e7feec5ba5643b4fa8b7fd54464778
change-id: 20260403-dev-mctp-fix-test-addr-4ee89cf80edc

Best regards,
--  
Jeremy Kerr <jk@codeconstruct.com.au>

Re: [PATCH net-next] net: mctp: tests: use actual address when creating dev with addr

[Simon Horman]

On Fri, Apr 03, 2026 at 10:21:04AM +0800, Jeremy Kerr wrote:
> Sashiko reports:
> 
> > This isn't a bug in the core networking code, but the addr parameter
> > appears to be ignored here.
> 
> In mctp_test_create_dev_with_addr(), we are ignoring the addr argument
> and just using `8`. Use the passed address instead.
> 
> All invocations use 8 anyway, so no effective change at present.
> 
> Fixes: 22cb45afd221 ("net: mctp: perform source address lookups when we populate our dst")
> Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>

Reviewed-by: Simon Horman <horms@verge.net.au>

Re: [PATCH net-next] net: mctp: tests: use actual address when creating dev with addr

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Fri, 03 Apr 2026 10:21:04 +0800 you wrote:
> Sashiko reports:
> 
> > This isn't a bug in the core networking code, but the addr parameter
> > appears to be ignored here.
> 
> In mctp_test_create_dev_with_addr(), we are ignoring the addr argument
> and just using `8`. Use the passed address instead.
> 
> [...]

Here is the summary with links:
  - [net-next] net: mctp: tests: use actual address when creating dev with addr
    https://git.kernel.org/netdev/net-next/c/70e32aadb5ca

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html