public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] devlink: Fix incorrect skb socket family dumping
@ 2026-04-07  2:27 lirongqing
  2026-04-09  2:50 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 2+ messages in thread
From: lirongqing @ 2026-04-07  2:27 UTC (permalink / raw)
  To: Jiri Pirko, David S . Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Simon Horman, Mateusz Polchlopek, Tony Nguyen,
	Przemek Kitszel, netdev, linux-kernel
  Cc: Li RongQing

From: Li RongQing <lirongqing@baidu.com>

The devlink_fmsg_dump_skb function was incorrectly using the socket
type (sk->sk_type) instead of the socket family (sk->sk_family)
when filling the "family" field in the fast message dump.

This patch fixes this to properly display the socket family.

Fixes: 3dbfde7f6bc7b8 ("devlink: add devlink_fmsg_dump_skb() function")
Signed-off-by: Li RongQing <lirongqing@baidu.com>
---
 net/devlink/health.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/devlink/health.c b/net/devlink/health.c
index 449c761..ea7a334 100644
--- a/net/devlink/health.c
+++ b/net/devlink/health.c
@@ -1327,7 +1327,7 @@ void devlink_fmsg_dump_skb(struct devlink_fmsg *fmsg, const struct sk_buff *skb)
 	if (sk) {
 		devlink_fmsg_pair_nest_start(fmsg, "sk");
 		devlink_fmsg_obj_nest_start(fmsg);
-		devlink_fmsg_put(fmsg, "family", sk->sk_type);
+		devlink_fmsg_put(fmsg, "family", sk->sk_family);
 		devlink_fmsg_put(fmsg, "type", sk->sk_type);
 		devlink_fmsg_put(fmsg, "proto", sk->sk_protocol);
 		devlink_fmsg_obj_nest_end(fmsg);
-- 
2.9.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] devlink: Fix incorrect skb socket family dumping
  2026-04-07  2:27 [PATCH] devlink: Fix incorrect skb socket family dumping lirongqing
@ 2026-04-09  2:50 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-04-09  2:50 UTC (permalink / raw)
  To: lirongqing
  Cc: jiri, davem, edumazet, kuba, pabeni, horms, mateusz.polchlopek,
	anthony.l.nguyen, przemyslaw.kitszel, netdev, linux-kernel

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Mon, 6 Apr 2026 22:27:30 -0400 you wrote:
> From: Li RongQing <lirongqing@baidu.com>
> 
> The devlink_fmsg_dump_skb function was incorrectly using the socket
> type (sk->sk_type) instead of the socket family (sk->sk_family)
> when filling the "family" field in the fast message dump.
> 
> This patch fixes this to properly display the socket family.
> 
> [...]

Here is the summary with links:
  - devlink: Fix incorrect skb socket family dumping
    https://git.kernel.org/netdev/net/c/0006c6f1091b

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-04-09  2:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-07  2:27 [PATCH] devlink: Fix incorrect skb socket family dumping lirongqing
2026-04-09  2:50 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox