public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH net-next] tools: ynl: tests: fix leading space on Makefile target
@ 2026-04-08  7:19 Hangbin Liu
  2026-04-10  3:50 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 2+ messages in thread
From: Hangbin Liu @ 2026-04-08  7:19 UTC (permalink / raw)
  To: Donald Hunter, Jakub Kicinski, David S. Miller, Eric Dumazet,
	Paolo Abeni, Simon Horman
  Cc: netdev, linux-kernel, Hangbin Liu

The ../generated/protos.a rule had a spurious leading space before the
target name. In make, target rules must start at column 0; only recipe
lines are indented with a tab. The extra space caused make to misparse
the rule.

Remove the leading space to match the style of the adjacent
../lib/ynl.a rule.

Fixes: e0aa0c61758f ("tools: ynl: move samples to tests")
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
---
 tools/net/ynl/tests/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/net/ynl/tests/Makefile b/tools/net/ynl/tests/Makefile
index 2a02958c7039..9215e84cca05 100644
--- a/tools/net/ynl/tests/Makefile
+++ b/tools/net/ynl/tests/Makefile
@@ -50,7 +50,7 @@ all: $(TEST_GEN_PROGS) $(TEST_GEN_FILES)
 ../lib/ynl.a:
 	@$(MAKE) -C ../lib
 
- ../generated/protos.a:
+../generated/protos.a:
 	@$(MAKE) -C ../generated
 
 $(TEST_GEN_PROGS) $(TEST_GEN_FILES): %: %.c ../lib/ynl.a ../generated/protos.a

---
base-commit: e65d8b6f3092398efd7c74e722cb7a516d9a0d6d
change-id: 20260408-ynl_makefile-ee540ab81eea

Best regards,
-- 
Hangbin Liu <liuhangbin@gmail.com>


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH net-next] tools: ynl: tests: fix leading space on Makefile target
  2026-04-08  7:19 [PATCH net-next] tools: ynl: tests: fix leading space on Makefile target Hangbin Liu
@ 2026-04-10  3:50 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-04-10  3:50 UTC (permalink / raw)
  To: Hangbin Liu
  Cc: donald.hunter, kuba, davem, edumazet, pabeni, horms, netdev,
	linux-kernel

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Wed, 08 Apr 2026 15:19:05 +0800 you wrote:
> The ../generated/protos.a rule had a spurious leading space before the
> target name. In make, target rules must start at column 0; only recipe
> lines are indented with a tab. The extra space caused make to misparse
> the rule.
> 
> Remove the leading space to match the style of the adjacent
> ../lib/ynl.a rule.
> 
> [...]

Here is the summary with links:
  - [net-next] tools: ynl: tests: fix leading space on Makefile target
    https://git.kernel.org/netdev/net-next/c/42f9b4c6ef19

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-04-10  3:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-08  7:19 [PATCH net-next] tools: ynl: tests: fix leading space on Makefile target Hangbin Liu
2026-04-10  3:50 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox