From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3EE7B3002A0 for ; Sun, 12 Apr 2026 18:50:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776019834; cv=none; b=Le+XU/ZKfUKEOENUCT3JtAF6ms9hoaXtEKXVkqIVzXhTlBiPza2Zw/1GGQvGbXaQdy22BBbAylSVM/XVEBW/HJiiknh/jhqJxCKpv540aruqrCl6Ko/TzED2p/xQ8B8JYMy9V9JjHthRkL0viHZmCQuflyhP8HVd66M113KVxQg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776019834; c=relaxed/simple; bh=vW3TO8BFgYhaY6pnvCmZWVBwA6m8SDqUpUAW1353BtY=; h=Content-Type:MIME-Version:Subject:From:Message-Id:Date:References: In-Reply-To:To:Cc; b=PWfTkwl8ZI1feXaxu4MTKhxAysvpOoYXVDGPtDTiJA+r681XxJb3m/R/WgFUe1EAYuSnvptRJbsi7wYeOsw2dgeKY7dUK/gCtN++owPC7L2LWwe6qC7VJFfjZfDdNSGyqDgdnhGtxx3Am+X2XsTgYE8r0uSVO69op62jr61D1TE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=CImnb3A4; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="CImnb3A4" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2125BC19424; Sun, 12 Apr 2026 18:50:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776019834; bh=vW3TO8BFgYhaY6pnvCmZWVBwA6m8SDqUpUAW1353BtY=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=CImnb3A4f+sdJN5luf63J8wsiLLBzs62ScVFE3HoLFKTGLC/8KDWjhU8r362zqa4x NVId7kol9WJcE4Ks5YQa/WKEH/7VOz/5ummg4MNISDCgpZFUS8hax9rXb9erxk+nJf Y7HR/C606/X5O8BgXgw5u9xiBBG3vlaP3eUakIkf9I3zgX2TIyrZvt9g1A60zkmb3U jrC3gEWx7pg/Lt/8jnu4UwHmUatorEf9HfSU/RC4onvEzPRC18QSJf3hRZDfWVyL9I 02Ldt3GS9mGQqzzXp8ZejkL0SXp4HGzPH/Vxvv5CEoRDF5PFkbioGGBAGP9YcrU2Qg eV/gGFI9S5Y/w== Received: from [10.30.226.235] (localhost [IPv6:::1]) by aws-us-west-2-korg-oddjob-rhel9-1.codeaurora.org (Postfix) with ESMTP id B9E0F3809A8C; Sun, 12 Apr 2026 18:50:07 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH net v2] net_sched: fix skb memory leak in deferred qdisc drops From: patchwork-bot+netdevbpf@kernel.org Message-Id: <177601980655.3374222.12646638680165442754.git-patchwork-notify@kernel.org> Date: Sun, 12 Apr 2026 18:50:06 +0000 References: <20260408100044.4530-1-fmancera@suse.de> In-Reply-To: <20260408100044.4530-1-fmancera@suse.de> To: Fernando Fernandez Mancera Cc: netdev@vger.kernel.org, horms@kernel.org, pabeni@redhat.com, kuba@kernel.org, edumazet@google.com, davem@davemloft.net, damilola@aterlo.com Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski : On Wed, 8 Apr 2026 12:00:44 +0200 you wrote: > When the network stack cleans up the deferred list via qdisc_run_end(), > it operates on the root qdisc. If the root qdisc do not implement the > TCQ_F_DEQUEUE_DROPS flag the packets queue to free are never freed and > gets stranded on the child's local to_free list. > > Fix this by making qdisc_dequeue_drop() aware of the root qdisc. It > fetches the root qdisc and check for the TCQ_F_DEQUEUE_DROPS flag. If > the flag is present, the packet is appended directly to the root's > to_free list. Otherwise, drop it directly as it was done before the > optimization was implemented. > > [...] Here is the summary with links: - [net,v2] net_sched: fix skb memory leak in deferred qdisc drops https://git.kernel.org/netdev/net/c/a6bd339dbb35 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html