From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 144F472618 for ; Tue, 12 May 2026 01:20:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778548827; cv=none; b=Z4ejAx0GOP+ahN+xymi6BYftws/KH4wSCyBP57qmdfY7ySSkvSD5hK1nLWjLAaobE5asJNjr3ycXcf2Za2SKnbc7CIPut8tshZmoFdvNbKww25duT6AEVL2sbkLHJznabtgIh7wsm3+BSB8gTxY22bShZhvzV/g/5fHSIc8GVPQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778548827; c=relaxed/simple; bh=RFU/1OHHTzuqFkcEJI5i1DO4+2qF3nQ9kaBxSXGbiMU=; h=Content-Type:MIME-Version:Subject:From:Message-Id:Date:References: In-Reply-To:To:Cc; b=edOJuc9ATtxbTnFb0l6q7DsBlcQYdOfr3ml/hG791q6uqB6l+S7jMBFWFeTIBNNvmQ1VJlI4pjXYpC/IlMii6SAfsRu4BjDXSk4iam4IkEVB9qo+lxApofXGLXrXvKAJE0H6dnjcpckzEmkmoCfFh4HEPA+KiWJ3TdTR4SRYq6c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=me5j//2X; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="me5j//2X" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C2F86C2BCB0; Tue, 12 May 2026 01:20:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778548826; bh=RFU/1OHHTzuqFkcEJI5i1DO4+2qF3nQ9kaBxSXGbiMU=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=me5j//2XgKIXdGAgBxMb6T/ta6McVyrj9nRy++CdBk0LMo5C9m+okEI0hZoG0LsMG BeyRiEw6l7L4wvqtmxNR15+XBKqkv64Zj82YgF7m7IZ4HowSMo4B6hM3Kw1kdUUi2V q9H429KGHbuKwZ9GuFMAk4QDiIoaSu5s0GZTeghEwOB1rwLqRMisGS9+y+xuARICpe q268QvEOPIY/dhJ50maTWvQ4Z4EpBQEoYVFyuYJ7jr6Y9wHBJR8eBCsrQWXPgrZt6S PgF/ZgctRmNr3Mks9q7mHkEWve9urehKfvIaQeoH5BuYirqRRnR9G5BjDaAldOIgZt Dd7oB6E5bTpWg== Received: from [10.30.226.235] (localhost [IPv6:::1]) by aws-us-west-2-korg-oddjob-rhel9-1.codeaurora.org (Postfix) with ESMTP id 7CF0C39308E4; Tue, 12 May 2026 01:19:34 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH net v2] net/sched: dualpi2: initialize timer earlier in dualpi2_init() From: patchwork-bot+netdevbpf@kernel.org Message-Id: <177854877304.2528168.12550829856617698082.git-patchwork-notify@kernel.org> Date: Tue, 12 May 2026 01:19:33 +0000 References: <1faca91179702b31da5d87653e1e036543e32722.1778259798.git.dcaratti@redhat.com> In-Reply-To: <1faca91179702b31da5d87653e1e036543e32722.1778259798.git.dcaratti@redhat.com> To: Davide Caratti Cc: jhs@mojatatu.com, jiri@resnulli.us, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, netdev@vger.kernel.org Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski : On Fri, 8 May 2026 19:05:10 +0200 you wrote: > 'pi2_timer' needs to be initialized in all error paths of dualpi2_init(): > otherwise, a failure in qdisc_create_dflt() causes the following crash in > dualpi2_destroy(): > > # tc qdisc add dev crash0 handle 1: root dualpi2 > BUG: kernel NULL pointer dereference, address: 0000000000000010 > #PF: supervisor read access in kernel mode > #PF: error_code(0x0000) - not-present page > PGD 0 P4D 0 > Oops: Oops: 0000 [#1] SMP PTI > CPU: 4 UID: 0 PID: 471 Comm: tc Tainted: G E 7.1.0-rc1-virtme #2 PREEMPT(full) > Tainted: [E]=UNSIGNED_MODULE > Hardware name: Bochs Bochs, BIOS Bochs 01/01/2011 > RIP: 0010:hrtimer_active+0x39/0x60 > Code: f9 eb 23 0f b6 41 38 3c 01 0f 87 87 64 c0 ff 83 e0 01 75 33 48 39 4a 50 74 28 44 3b 42 10 75 06 48 3b 51 30 74 21 48 8b 51 30 <44> 8b 42 10 41 f6 c0 01 74 cf f3 90 44 8b 42 10 41 f6 c0 01 74 c3 > RSP: 0018:ffffd0db80b93620 EFLAGS: 00010282 > RAX: ffffffffc0400320 RBX: ffff8cf24a4c86b8 RCX: ffff8cf24a4c86b8 > RDX: 0000000000000000 RSI: ffff8cf2429c2ab0 RDI: ffff8cf24a4c86b8 > RBP: 00000000fffffff4 R08: 0000000000000003 R09: 0000000000000000 > R10: 0000000000000001 R11: ffff8cf24a39c500 R12: ffff8cf24822c000 > R13: ffffd0db80b936c0 R14: ffffffffc02cf360 R15: 00000000ffffffff > FS: 00007fbc01706580(0000) GS:ffff8cf2dc759000(0000) knlGS:0000000000000000 > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > CR2: 0000000000000010 CR3: 0000000008e02003 CR4: 0000000000172ef0 > Call Trace: > > hrtimer_cancel+0x15/0x40 > dualpi2_destroy+0x20/0x40 [sch_dualpi2] > qdisc_create+0x230/0x570 > tc_modify_qdisc+0x716/0xc10 > rtnetlink_rcv_msg+0x188/0x780 > netlink_rcv_skb+0xcd/0x150 > netlink_unicast+0x1ba/0x290 > netlink_sendmsg+0x242/0x4d0 > ____sys_sendmsg+0x39e/0x3e0 > ___sys_sendmsg+0xe1/0x130 > __sys_sendmsg+0xad/0x110 > do_syscall_64+0x14f/0xf80 > entry_SYSCALL_64_after_hwframe+0x77/0x7f > RIP: 0033:0x7fbc0188b08e > Code: 4d 89 d8 e8 94 bd 00 00 4c 8b 5d f8 41 8b 93 08 03 00 00 59 5e 48 83 f8 fc 74 11 c9 c3 0f 1f 80 00 00 00 00 48 8b 45 10 0f 05 c3 83 e2 39 83 fa 08 75 e7 e8 03 ff ff ff 0f 1f 00 f3 0f 1e fa > RSP: 002b:00007fff593260e0 EFLAGS: 00000202 ORIG_RAX: 000000000000002e > RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007fbc0188b08e > RDX: 0000000000000000 RSI: 00007fff59326190 RDI: 0000000000000003 > RBP: 00007fff593260f0 R08: 0000000000000000 R09: 0000000000000000 > R10: 0000000000000000 R11: 0000000000000202 R12: 000055f06124f260 > R13: 0000000069fca043 R14: 000055f061255640 R15: 000055f06124d3f8 > > Modules linked in: sch_dualpi2(E) > CR2: 0000000000000010 > > [...] Here is the summary with links: - [net,v2] net/sched: dualpi2: initialize timer earlier in dualpi2_init() https://git.kernel.org/netdev/net/c/f8e64e956a63 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html