From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC973394464 for ; Tue, 2 Jun 2026 18:40:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780425605; cv=none; b=rFqJoZr6JLQsaUGfsKn5sv8aWzoAZ1/A0GsENZbQK3ns3sCL5YdxJ2X+1Z5kWuKg9iQ+d7FdbtXsIyKH6JyWejxVdFciIqPpILYrHy+c9a9Wql/Y9hwuL9gom575SbX4UugSHDcoy+51YvJIjKA+ihhwcFfO32R3r6dHwmQFbGk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780425605; c=relaxed/simple; bh=8M8Q0Li5FIHV/6PSPWoVEoBJpuKvr9z2v901B0jn7Yc=; h=Content-Type:MIME-Version:Subject:From:Message-Id:Date:References: In-Reply-To:To:Cc; b=std9aUeOLRxmgL7C+gXQwdtaDrL/Njbunlewt3v4zMjQvpQq31Ss+SOI2l+3/Qdu8bsh9Fq1L/u1i5iAWMdm6GiNiY4NaSCLcMp6JfkvK3pXl4MN7HMTHuIJ2dn+eXUa30WALcfW+M5U1QqAU5i9o/7SkN5m6o0enRVZSA3b7gE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Wut2fUV3; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Wut2fUV3" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 76CD71F00893; Tue, 2 Jun 2026 18:40:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780425604; bh=6Ur6CjCoSIvmft0BHxLHcPnMMVlpfcDath+nGhigIvM=; h=Subject:From:Date:References:In-Reply-To:To:Cc; b=Wut2fUV3SbQ+WcVbzOg29q/YoLDvYU03POuWr9TgwWlvpc59wjvviku3/NCrQ4fgT KI4iUozdLa0d5VJmsqyq270nW6Iweb0IGGczOYU/j3PTnv+JiDCljiE2m/PMjvtZMm XBP2fnGm6uQJAEov6uaQr9+eV5rWqntwvdoUm8OCxSoIUxKILSblPggLP8YkjFFQ0g z59+QD26mng7wtb8s/9M/cjHAkj3hA2gJgmbsRVphoQPIvsYsAm6XM2ZbHdRzFfx3K S+9uI2jhnG0yi9MfdjrDtLYVqGfO28Ilv5IsUFF0KKKI77v/JV9wyKAx93RO9mjaTn GpgrBECiNI78w== Received: from [10.30.226.235] (localhost [IPv6:::1]) by aws-us-west-2-korg-oddjob-rhel9-1.codeaurora.org (Postfix) with ESMTP id 93B123811A6C; Tue, 2 Jun 2026 18:40:07 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH net] pcnet32: stop holding device spin lock during napi_complete_done From: patchwork-bot+netdevbpf@kernel.org Message-Id: <178042560607.1000369.13107757515393374597.git-patchwork-notify@kernel.org> Date: Tue, 02 Jun 2026 18:40:06 +0000 References: <20260528140320.5556-1-oscmaes92@gmail.com> In-Reply-To: <20260528140320.5556-1-oscmaes92@gmail.com> To: Oscar Maes Cc: netdev@vger.kernel.org, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew@lunn.ch Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski : On Thu, 28 May 2026 16:03:20 +0200 you wrote: > napi_complete_done may call gro_flush_normal (though not currently, as GRO > is unsupported at the moment), which may result in packet TX. This will > eventually result in calling pcnet32_start_xmit - resulting in a deadlock > while trying to re-acquire the already locked spin lock. > > It is safe to split the spinlock block into two, because the hardware > registers are still protected from concurrent access, and the two blocks > perform unrelated operations that don't need to happen atomically. > > [...] Here is the summary with links: - [net] pcnet32: stop holding device spin lock during napi_complete_done https://git.kernel.org/netdev/net/c/73bf3cca7de6 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html