From: patchwork-bot+netdevbpf@kernel.org
To: Xiang Mei <xmei5@asu.edu>
Cc: daniel@iogearbox.net, martin.lau@linux.dev, hawk@kernel.org,
jiayuan.chen@linux.dev, netdev@vger.kernel.org,
bpf@vger.kernel.org, john.fastabend@gmail.com, sdf@fomichev.me,
ast@kernel.org, joamaki@gmail.com, pabeni@redhat.com,
bestswngs@gmail.com
Subject: Re: [PATCH net] net, bpf: check master for NULL in xdp_master_redirect()
Date: Tue, 23 Jun 2026 21:10:06 +0000 [thread overview]
Message-ID: <178224900627.2420505.10383467266563822848.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20260620201531.180123-1-xmei5@asu.edu>
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Sat, 20 Jun 2026 13:15:31 -0700 you wrote:
> xdp_master_redirect() dereferences the result of
> netdev_master_upper_dev_get_rcu() without a NULL check, but that helper
> returns NULL when the receiving device has no upper-master adjacency.
>
> The reach guard only checks netif_is_bond_slave(). On bond slave release
> bond_upper_dev_unlink() drops the upper-master adjacency before clearing
> IFF_SLAVE, so an XDP_TX reaching xdp_master_redirect() in that window
> still passes netif_is_bond_slave() while master is already NULL, and
> faults on master->flags at offset 0xb0:
>
> [...]
Here is the summary with links:
- [net] net, bpf: check master for NULL in xdp_master_redirect()
https://git.kernel.org/netdev/net/c/e82d8cc4321c
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2026-06-23 21:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-20 20:15 [PATCH net] net, bpf: check master for NULL in xdp_master_redirect() Xiang Mei
2026-06-22 1:21 ` Jiayuan Chen
2026-06-22 1:28 ` Xiang Mei
2026-06-22 22:58 ` Jakub Kicinski
2026-06-22 23:34 ` Xiang Mei
2026-06-23 6:52 ` Ido Schimmel
2026-06-23 10:08 ` Jiayuan Chen
2026-06-23 20:43 ` Jakub Kicinski
2026-06-23 21:10 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178224900627.2420505.10383467266563822848.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=ast@kernel.org \
--cc=bestswngs@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=hawk@kernel.org \
--cc=jiayuan.chen@linux.dev \
--cc=joamaki@gmail.com \
--cc=john.fastabend@gmail.com \
--cc=martin.lau@linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=xmei5@asu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox