From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7222136826B; Thu, 25 Jun 2026 01:09:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782349757; cv=none; b=lfqzDQPJj2kaZXTLdlS3L00y39hcFUIBEFmU9DTJ0eSZLXZIk9ALQIJcGYmhFSCwf0CCu2xiQwPhAEpfvkXJj/X7F7Px+aa7WprM04khbrQPHjGUmuoUpn8Vgv4EgcUuIe6Udg+1/SvJaw40MZRnmQkbYDkj85jUYj6C8MHsWt0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782349757; c=relaxed/simple; bh=kpewF/rPWYxnFccLuqdraPbJuV36lrpciYeSlOO0RL8=; h=Content-Type:MIME-Version:Subject:From:Message-Id:Date:References: In-Reply-To:To:Cc; b=AZQDImH7pu5n7a+v3TzEihF7Aw8iBxpSLOd83QwqB5sciTGYcTger/tqGrkerKwGgMhjZheBs8d9iSAJjAzecWWpurEdYw33RthLsRtWdPBFF1PegpfZMDpY0ZWC6tfmEU7mKYwe0OeYDquFQF2Sog+WQiVHXj3DcreTB+zltdA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=PbZ/x6Ax; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="PbZ/x6Ax" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 554D11F00A3F; Thu, 25 Jun 2026 01:09:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782349754; bh=KSyb2XtjEX1eDUWv4A7qcjknp0JqfZehvr6jo6mvFpQ=; h=Subject:From:Date:References:In-Reply-To:To:Cc; b=PbZ/x6AxRAkXBIuusdBvANE1T1Xci4UQYkbzLietEy3tEwW8JIIbSUFemeol83U9u L+ZRikNvzDk75UOKiPuVc897sCx2Xudm7R+Luq9amk8LAO6dxPMYRgKGaTwUkgIlCC CXCpie0saI26iqyK03XESK5xvdSjmxi/5eG0OYlgWp6Plrc6xzpiqlcTCuQSQIIa7T Jp/HYmsAetYV67GMmVNIXq1EqBSwTMK0FKOZ2OoECsr4BtavZnq7YHZD0wnfg++RfU ruonreID+5nIc0PfzQ4HWC+DsmFGME3wBGKnsuZnNi5AcLrDFU3OK1l3/XKKrvO9nV UXvqLrD8RFTbQ== Received: from [10.30.226.235] (localhost [IPv6:::1]) by aws-us-west-2-korg-oddjob-rhel9-1.codeaurora.org (Postfix) with ESMTP id D0CD93AAA0F5; Thu, 25 Jun 2026 01:09:03 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH] net: ixp4xx_hss: fix duplicate HDLC netdev allocation From: patchwork-bot+netdevbpf@kernel.org Message-Id: <178234974236.3045401.8869362652520123568.git-patchwork-notify@kernel.org> Date: Thu, 25 Jun 2026 01:09:02 +0000 References: <20260622043015.643637-1-haoxiang_li2024@163.com> In-Reply-To: <20260622043015.643637-1-haoxiang_li2024@163.com> To: Haoxiang Li Cc: linusw@kernel.org, kaloz@openwrt.org, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, huangguangbin2@huawei.com, lipeng321@huawei.com, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski : On Mon, 22 Jun 2026 12:30:15 +0800 you wrote: > ixp4xx_hss_probe() allocates two HDLC netdevs. The first one is stored > in ndev, initialized, and registered with register_hdlc_device(). The > second one is stored in port->netdev and later used by the remove path > for unregister_hdlc_device() and free_netdev(). > > This means that the registered netdev is not the same object that is > unregistered and freed on remove. It also leaks the first allocation if > the second alloc_hdlcdev() call fails, and the first allocation is not > checked before ndev is used. > > [...] Here is the summary with links: - net: ixp4xx_hss: fix duplicate HDLC netdev allocation https://git.kernel.org/netdev/net/c/db818b0e8af7 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html