From: Guenter Roeck <linux@roeck-us.net>
To: Andrew Lunn <andrew@lunn.ch>, a0282524688@gmail.com
Cc: tmyu0@nuvoton.com, linusw@kernel.org, brgl@kernel.org,
andi.shyti@kernel.org, lee@kernel.org, mkl@pengutronix.de,
mailhol@kernel.org, alexandre.belloni@bootlin.com,
wim@linux-watchdog.org, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-can@vger.kernel.org, netdev@vger.kernel.org,
linux-watchdog@vger.kernel.org, linux-hwmon@vger.kernel.org,
linux-rtc@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH v4 1/1] mfd: Add Host Interface (HIF) support for Nuvoton NCT6694
Date: Fri, 15 May 2026 07:04:22 -0700 [thread overview]
Message-ID: <17828a1b-86c7-4ad6-a93b-3f91c6b2c24f@roeck-us.net> (raw)
In-Reply-To: <ef9449dc-ef2a-415e-8acc-a15f349bac24@lunn.ch>
On 5/15/26 05:41, Andrew Lunn wrote:
>> MAINTAINERS | 1 +
>> drivers/gpio/gpio-nct6694.c | 7 -
>> drivers/hwmon/nct6694-hwmon.c | 21 -
>> drivers/i2c/busses/i2c-nct6694.c | 7 -
>> drivers/mfd/Kconfig | 47 +-
>> drivers/mfd/Makefile | 3 +-
>> drivers/mfd/nct6694-hif.c | 663 ++++++++++++++++++++++++++++
>> drivers/mfd/nct6694.c | 111 +++--
>> drivers/net/can/usb/nct6694_canfd.c | 6 -
>
> The networking change here is very small, so my influence as a
> networking Maintainer should be considered small.
>
> However, i would say this patch is too big, does too many different
> things at once, making it harder to review. Please could you break it
> up into lots of small patches, each with good commit messages, and
> being obviously correct.
>
Add my influence as hardware monitoring maintainer. I very much agree.
Guenter
prev parent reply other threads:[~2026-05-15 14:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 8:57 [PATCH v4 0/1] mfd: nct6694: Refactor transport layer and add HIF (eSPI) support a0282524688
2026-05-15 8:57 ` [PATCH v4 1/1] mfd: Add Host Interface (HIF) support for Nuvoton NCT6694 a0282524688
2026-05-15 12:41 ` Andrew Lunn
2026-05-15 14:04 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17828a1b-86c7-4ad6-a93b-3f91c6b2c24f@roeck-us.net \
--to=linux@roeck-us.net \
--cc=a0282524688@gmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andi.shyti@kernel.org \
--cc=andrew@lunn.ch \
--cc=brgl@kernel.org \
--cc=lee@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=mailhol@kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=tmyu0@nuvoton.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox