From: patchwork-bot+netdevbpf@kernel.org
To: Ivan Vecera <ivecera@redhat.com>
Cc: netdev@vger.kernel.org, vadim.fedorenko@linux.dev,
arkadiusz.kubalewski@intel.com, jiri@resnulli.us,
przemyslaw.kitszel@intel.com, milena.olech@intel.com,
kuba@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] dpll: fix NULL pointer dereference in dpll_msg_add_pin_ref_sync()
Date: Fri, 17 Jul 2026 10:10:05 +0000 [thread overview]
Message-ID: <178428300580.1646936.7009191466298129305.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20260710193625.1378822-1-ivecera@redhat.com>
Hello:
This patch was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@redhat.com>:
On Fri, 10 Jul 2026 21:36:25 +0200 you wrote:
> When a dpll_pin is shared across multiple dpll_device instances and
> those devices are being unregistered (e.g. during driver module removal),
> a NULL pointer dereference can occur in dpll_msg_add_pin_ref_sync().
>
> This happens under the following conditions:
> - A pin is registered with two or more dpll devices (dpll_A, dpll_B)
> - The pin has ref_sync pairs with other pins
> - During unregistration of dpll_A's pins, a ref_sync partner pin is
> unregistered first, removing it from dpll_A->pin_refs
> - But since the partner pin is still registered with dpll_B, its
> dpll_refs is not empty, so dpll_pin_ref_sync_pair_del() does NOT
> run and the partner stays in the pin's ref_sync_pins xarray
> - When the pin itself is then unregistered from dpll_A, the delete
> notification calls dpll_msg_add_pin_ref_sync() which finds the
> partner in ref_sync_pins, passes dpll_pin_available() (partner is
> still registered with dpll_B), but dpll_pin_on_dpll_priv(dpll_A,
> partner) returns NULL because partner was already removed from
> dpll_A->pin_refs
> - The NULL priv pointer is passed to the driver's ref_sync_get
> callback, which dereferences it
>
> [...]
Here is the summary with links:
- [net] dpll: fix NULL pointer dereference in dpll_msg_add_pin_ref_sync()
https://git.kernel.org/netdev/net/c/d2e914a4a0d0
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2026-07-17 10:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-10 19:36 [PATCH net] dpll: fix NULL pointer dereference in dpll_msg_add_pin_ref_sync() Ivan Vecera
2026-07-10 22:56 ` Vadim Fedorenko
2026-07-13 8:56 ` Jiri Pirko
2026-07-17 10:10 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178428300580.1646936.7009191466298129305.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=arkadiusz.kubalewski@intel.com \
--cc=ivecera@redhat.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=milena.olech@intel.com \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox