Netdev List
 help / color / mirror / Atom feed
From: patchwork-bot+netdevbpf@kernel.org
To: Satish Kharat <satishkh@cisco.com>
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
	kuba@kernel.org, pabeni@redhat.com, sebaddel@cisco.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] enic: fix tx_hang_reset use-after-free on device removal
Date: Fri, 31 Jul 2026 00:00:11 +0000	[thread overview]
Message-ID: <178545601163.49120.14528411223572589107.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20260728062730.2394873-1-satishkh@cisco.com>

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Mon, 27 Jul 2026 23:26:30 -0700 you wrote:
> enic_remove() cancels the reset and change_mtu_work items but does not
> cancel tx_hang_reset. A TX timeout that fires while the device is being
> removed can schedule enic_tx_hang_reset() so that it runs after
> free_netdev(), resulting in a use-after-free.
> 
> cancel_work_sync() alone is not sufficient here: the still-live watchdog
> and notify paths can re-schedule these work items in the window between
> the cancel and unregister_netdev(). Use disable_work_sync(), which
> cancels the work and blocks any subsequent schedule_work() from
> requeuing it, and apply it to the reset and change_mtu_work items as
> well so the same requeue race is closed for all teardown work.
> 
> [...]

Here is the summary with links:
  - [net] enic: fix tx_hang_reset use-after-free on device removal
    https://git.kernel.org/netdev/net/c/ec680ea4ba1b

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



      reply	other threads:[~2026-07-31  0:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-28  6:26 [PATCH net] enic: fix tx_hang_reset use-after-free on device removal Satish Kharat
2026-07-31  0:00 ` patchwork-bot+netdevbpf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178545601163.49120.14528411223572589107.git-patchwork-notify@kernel.org \
    --to=patchwork-bot+netdevbpf@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=satishkh@cisco.com \
    --cc=sebaddel@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox