From: "Rob Herring (Arm)" <robh@kernel.org>
To: Changhuang Liang <changhuang.liang@starfivetech.com>
Cc: Paul Walmsley <pjw@kernel.org>,
Hal Feng <hal.feng@starfivetech.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Palmer Dabbelt <palmer@dabbelt.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Conor Dooley <conor+dt@kernel.org>,
linux-hardening@vger.kernel.org, Alexandre Ghiti <alex@ghiti.fr>,
linux-clk@vger.kernel.org,
Emil Renner Berthing <kernel@esmil.dk>,
Stephen Boyd <sboyd@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Kees Cook <kees@kernel.org>, Albert Ou <aou@eecs.berkeley.edu>,
"Gustavo A . R . Silva" <gustavoars@kernel.org>,
Richard Cochran <richardcochran@gmail.com>,
devicetree@vger.kernel.org, linux-riscv@lists.infradead.org
Subject: Re: [PATCH v3 15/22] dt-bindings: clock: Add StarFive JHB100 Peripheral-1 clock and reset generator
Date: Fri, 07 Aug 2026 08:02:31 -0500 [thread overview]
Message-ID: <178610775180.4069377.7068076405963189133.robh@kernel.org> (raw)
In-Reply-To: <20260807112923.191627-16-changhuang.liang@starfivetech.com>
On Fri, 07 Aug 2026 04:29:16 -0700, Changhuang Liang wrote:
> Add bindings for the Peripheral-1 clock and reset generator (PER1CRG)
> on the JHB100 RISC-V SoC by StarFive Ltd.
>
> Signed-off-by: Changhuang Liang <changhuang.liang@starfivetech.com>
> Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
> ---
> .../clock/starfive,jhb100-per1crg.yaml | 70 +++++++++++++++++++
> .../dt-bindings/clock/starfive,jhb100-crg.h | 60 ++++++++++++++++
> .../dt-bindings/reset/starfive,jhb100-crg.h | 19 +++++
> 3 files changed, 149 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/clock/starfive,jhb100-per1crg.yaml
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/display/mediatek/mediatek,mt8196-tdshp.example.dtb: tdshp@321e0000 (mediatek,mt8196-disp-tdshp): 'clock-names' is a required property
from schema $id: http://devicetree.org/schemas/display/mediatek/mediatek,mt8196-tdshp.yaml
Documentation/devicetree/bindings/display/imx/fsl,imx-lcdc.example.dtb: display0: fsl,pcr: b'\xf0\xc8\x80\x80' is not of type 'object', 'integer', 'array', 'boolean', 'null'
from schema $id: http://devicetree.org/schemas/dt-core.yaml
doc reference errors (make refcheckdocs):
See https://patchwork.kernel.org/project/devicetree/patch/20260807112923.191627-16-changhuang.liang@starfivetech.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2026-08-07 13:02 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-07 11:29 [PATCH v3 00/22] Add basic clocks and resets for JHB100 SoC Changhuang Liang
2026-08-07 11:29 ` [PATCH v3 01/22] reset: starfive: Rename file name "jh71x0" to "common" Changhuang Liang
2026-08-07 11:29 ` [PATCH v3 02/22] reset: starfive: Convert the word "jh71x0" to "starfive" Changhuang Liang
2026-08-07 11:29 ` [PATCH v3 03/22] clk: starfive: Rename file name "jh71x0" to "common" Changhuang Liang
2026-08-07 11:29 ` [PATCH v3 04/22] clk: starfive: Convert the word "jh71x0" to "starfive" Changhuang Liang
2026-08-07 11:29 ` [PATCH v3 05/22] dt-bindings: clock: Add StarFive JHB100 System-0 clock and reset generator Changhuang Liang
2026-08-07 11:29 ` [PATCH v3 06/22] clk: starfive: Add JHB100 System-0 clock generator driver Changhuang Liang
2026-08-07 11:29 ` [PATCH v3 07/22] dt-bindings: clock: Add StarFive JHB100 System-1 clock and reset generator Changhuang Liang
2026-08-07 11:29 ` [PATCH v3 08/22] clk: starfive: Add JHB100 System-1 clock generator driver Changhuang Liang
2026-08-07 11:29 ` [PATCH v3 09/22] dt-bindings: clock: Add StarFive JHB100 System-2 clock and reset generator Changhuang Liang
2026-08-07 11:29 ` [PATCH v3 10/22] clk: starfive: Add JHB100 System-2 clock generator driver Changhuang Liang
2026-08-07 11:29 ` [PATCH v3 11/22] dt-bindings: clock: Add StarFive JHB100 Peripheral-0 clock and reset generator Changhuang Liang
2026-08-07 11:29 ` [PATCH v3 12/22] clk: starfive: Introduce inverter and divider Changhuang Liang
2026-08-07 11:29 ` [PATCH v3 13/22] clk: starfive: Expand the storage of clock parent index Changhuang Liang
2026-08-07 11:29 ` [PATCH v3 14/22] clk: starfive: Add StarFive JHB100 Peripheral-0 clock driver Changhuang Liang
2026-08-07 11:29 ` [PATCH v3 15/22] dt-bindings: clock: Add StarFive JHB100 Peripheral-1 clock and reset generator Changhuang Liang
2026-08-07 13:02 ` Rob Herring (Arm) [this message]
2026-08-07 11:29 ` [PATCH v3 16/22] clk: starfive: Add StarFive JHB100 Peripheral-1 clock driver Changhuang Liang
2026-08-07 11:29 ` [PATCH v3 17/22] dt-bindings: clock: Add StarFive JHB100 Peripheral-2 clock and reset generator Changhuang Liang
2026-08-07 11:29 ` [PATCH v3 18/22] clk: starfive: Add StarFive JHB100 Peripheral-2 clock driver Changhuang Liang
2026-08-07 11:29 ` [PATCH v3 19/22] dt-bindings: clock: Add StarFive JHB100 Peripheral-3 clock and reset generator Changhuang Liang
2026-08-07 11:29 ` [PATCH v3 20/22] clk: starfive: Add StarFive JHB100 Peripheral-3 clock driver Changhuang Liang
2026-08-07 11:29 ` [PATCH v3 21/22] reset: starfive: Add StarFive JHB100 reset driver Changhuang Liang
2026-08-07 11:29 ` [PATCH v3 22/22] riscv: dts: starfive: jhb100: Add clocks and resets nodes Changhuang Liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178610775180.4069377.7068076405963189133.robh@kernel.org \
--to=robh@kernel.org \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=changhuang.liang@starfivetech.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gustavoars@kernel.org \
--cc=hal.feng@starfivetech.com \
--cc=kees@kernel.org \
--cc=kernel@esmil.dk \
--cc=krzk+dt@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=netdev@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
--cc=richardcochran@gmail.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox