Netdev List
 help / color / mirror / Atom feed
From: patchwork-bot+netdevbpf@kernel.org
To: Harshit Varu <harshitvaru666@gmail.com>
Cc: netdev@vger.kernel.org, mptcp@lists.linux.dev,
	matttbe@kernel.org, martineau@kernel.org, geliang@kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH net] mptcp: fix uninitialized local_id in syncookie MP_JOIN reconstruction
Date: Thu, 20 Aug 2026 20:00:08 +0000	[thread overview]
Message-ID: <178725600863.460874.9689834140806639279.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20260815115205.197151-1-harshitvaru666@gmail.com>

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Sat, 15 Aug 2026 17:22:05 +0530 you wrote:
> mptcp_token_join_cookie_init_state() restores remote_nonce, local_nonce,
> backup, join_id, token and msk from the saved cookie entry when rebuilding
> the request socket for a MP_JOIN 4th-ACK handled under SYN cookies, but it
> does not restore local_id, even though the SYN path saved it.
> subflow_ulp_clone() then reads that uninitialized field and stores it as
> the joined subflow's address-ID. Because the request-sock slab is
> SLAB_TYPESAFE_BY_RCU and not zeroed on allocation, the value is the stale
> byte of a previously freed request socket, which an off-path peer can
> influence by sending concurrent MP_JOIN SYNs. This corrupts the path
> manager's id-based subflow bookkeeping for the connection.
> 
> [...]

Here is the summary with links:
  - [net] mptcp: fix uninitialized local_id in syncookie MP_JOIN reconstruction
    https://git.kernel.org/netdev/net/c/b878dfdd12d7

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



      parent reply	other threads:[~2026-08-20 20:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-15 11:52 [PATCH net] mptcp: fix uninitialized local_id in syncookie MP_JOIN reconstruction Harshit Varu
2026-08-16 17:31 ` Matthieu Baerts
2026-08-20 20:00 ` patchwork-bot+netdevbpf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178725600863.460874.9689834140806639279.git-patchwork-notify@kernel.org \
    --to=patchwork-bot+netdevbpf@kernel.org \
    --cc=geliang@kernel.org \
    --cc=harshitvaru666@gmail.com \
    --cc=martineau@kernel.org \
    --cc=matttbe@kernel.org \
    --cc=mptcp@lists.linux.dev \
    --cc=netdev@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox