From: patchwork-bot+netdevbpf@kernel.org
To: Nicolai Buchwitz <nb@tipi-net.de>
Cc: netdev@vger.kernel.org, theo.lebrun@bootlin.com,
conor.dooley@microchip.com, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, david.laight.linux@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: macb: exclude software FCS from TX byte statistics
Date: Thu, 03 Sep 2026 02:30:10 +0000 [thread overview]
Message-ID: <178840261090.3050934.7632746277544559687.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20260831113128.1678674-1-nb@tipi-net.de>
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Mon, 31 Aug 2026 13:31:28 +0200 you wrote:
> Frames for which macb_pad_and_fcs() supplies the FCS have four FCS
> bytes appended, and TX completion then accounts the grown skb->len.
> tx_bytes is defined to exclude the FCS, so these frames are reported
> four bytes too large.
>
> Track only the number of FCS bytes appended in software, 0 or
> ETH_FCS_LEN, and subtract that from skb->len at completion. skb->len
> already reflects the padded length by then, so there is nothing else
> to store. macb_pad_and_fcs() already returns 0 on every non-error
> path. Return the FCS length from there instead, rather than
> recomputing the same check in the caller. BQL stays on the padded
> skb->len that netdev_tx_sent_queue() saw.
>
> [...]
Here is the summary with links:
- [net] net: macb: exclude software FCS from TX byte statistics
https://git.kernel.org/netdev/net/c/d85f521a9afb
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2026-09-03 2:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-31 11:31 [PATCH net] net: macb: exclude software FCS from TX byte statistics Nicolai Buchwitz
2026-09-02 2:34 ` [net] " netdev-bot+sashiko
2026-09-03 2:30 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178840261090.3050934.7632746277544559687.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=conor.dooley@microchip.com \
--cc=davem@davemloft.net \
--cc=david.laight.linux@gmail.com \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nb@tipi-net.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=theo.lebrun@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox