Re: [PATCH net-next v3 2/4] net: mdio: realtek-rtl9300: Convert "fwnode" left-overs to "of"

[netdev-bot+sashiko@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue(s) to consider:

Critical: 0 · High: 0 · Medium: 0 · Low: 1

- [Low] Incomplete conversion vs. commit-message claim: the commit states
  it converts "the remaining 'fwnode' left-overs" of…

--

net: mdio: realtek-rtl9300: Convert "fwnode" left-overs to "of"

This converts otto_emdio_probe_one() to take a struct device_node instead
of a struct fwnode_handle, replaces fwnode_property_read_u32() with
of_property_read_u32(), drops the to_of_node() conversion for
devm_of_mdiobus_register(), and switches the child loop in
otto_emdio_probe() to for_each_available_child_of_node_scoped().

> The latest developments of the MDIO driver consistently used the
> "of" API. Convert the remaining "fwnode" left-overs too.

[Severity: Low]
Is the conversion of "the remaining fwnode left-overs" complete after this
patch?  otto_emdio_map_ports() still prints the parent node through the
fwnode API:

drivers/net/mdio/mdio-realtek-rtl9300.c:otto_emdio_map_ports() {
	ports_dn = of_get_child_by_name(parent->of_node, "ethernet-ports");
	if (!ports_dn)
		return dev_err_probe(dev, -EINVAL, "%pfwP missing ethernet-ports\n",
				     dev_fwnode(parent));
	...
}

The statement just above already uses parent->of_node, so would "%pOF" with
parent->of_node be the matching "of" form here?

A grep for fwnode in the file at this commit shows this dev_err_probe() call
as the only remaining user, and it is still unchanged at the end of the
series (5624848bce74bb4ff1882ee7fa047bde6f4e04aa), so should the commit
message be softened, or the print converted as well?

The message text itself is correct either way, and %pfwP on an OF-backed
fwnode still prints the node path, so this is only about the completeness
claim.

-- 
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260909150107.3602067-1-markus.stockhausen%40gmx.de