From: Arthur Kiyanovski <akiyano@amazon.com>
To: Guangshuo Li <lgs201920130244@gmail.com>
Cc: "Arthur Kiyanovski" <akiyano@amazon.com>,
"David Arinzon" <darinzon@amazon.com>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Sang-Heon Jeon" <ekffu200098@gmail.com>,
"Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>,
"Dawei Feng" <dawei.feng@seu.edu.cn>,
"Amit Bernstein" <amitbern@amazon.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] net: ena: fix PHC cleanup on probe failure
Date: Wed, 16 Sep 2026 05:44:00 +0000 [thread overview]
Message-ID: <178953744017.13037.8123570146284827976.b4-review@b4> (raw)
In-Reply-To: <20260916022954.2690322-1-lgs201920130244@gmail.com>
On Wed, 16 Sep 2026 10:29:54 +0800, Guangshuo Li <lgs201920130244@gmail.com> wrote:
> diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c b/drivers/net/ethernet/amazon/ena/ena_netdev.c
> index ea89619039d8..5f0864d16dd3 100644
> --- a/drivers/net/ethernet/amazon/ena/ena_netdev.c
> +++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c
> @@ -4122,6 +4122,7 @@ static int ena_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
> err_device_destroy:
> ena_com_delete_host_info(ena_dev);
> ena_com_admin_destroy(ena_dev);
> + ena_phc_destroy(adapter);
> ena_devlink_destroy:
> ena_devlink_free(devlink);
> err_metrics_destroy:
Thank you for the patch.
It looks correct.
Please resend this together with "net: ena: fix MMIO read buffer leak on
probe failure" as one two-patch series - both insert a line into the same
hunk, so they conflict with each other.
--
Arthur Kiyanovski <akiyano@amazon.com>
next prev parent reply other threads:[~2026-09-16 5:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-16 2:29 [PATCH] net: ena: fix PHC cleanup on probe failure Guangshuo Li
2026-09-16 5:44 ` Arthur Kiyanovski [this message]
2026-09-21 15:23 ` Guangshuo Li
2026-09-17 17:31 ` netdev-bot+sashiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178953744017.13037.8123570146284827976.b4-review@b4 \
--to=akiyano@amazon.com \
--cc=amitbern@amazon.com \
--cc=andrew+netdev@lunn.ch \
--cc=darinzon@amazon.com \
--cc=davem@davemloft.net \
--cc=dawei.feng@seu.edu.cn \
--cc=edumazet@google.com \
--cc=ekffu200098@gmail.com \
--cc=kuba@kernel.org \
--cc=lgs201920130244@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox