Re: [PATCH net-next v3 12/13] net/rds: drop rds_conn_count in favor of t_conn_count

[netdev-bot+sashiko@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue(s) to consider:

Critical: 0 · High: 0 · Medium: 0 · Low: 1

- [Low] The commit message of "net/rds: drop rds_conn_count in favor of
  t_conn_count" opens with "The previous patch gave each transport its…

--

net/rds: drop rds_conn_count in favor of t_conn_count

This patch seeds the per-path workqueue names in __rds_conn_create() from
trans->t_conn_count instead of the global rds_conn_count, and removes
rds_conn_count along with the rds_conn_lock round-trip that
rds_conn_destroy_fini() took solely to decrement it.

No Link: tags are present in the commit header.

> net/rds: drop rds_conn_count in favor of t_conn_count
>
>     The previous patch gave each transport its own connection count in
>     t_conn_count, incremented and decremented at exactly the points where
>     the global rds_conn_count is.

[Severity: Low]
Is "the previous patch" the right reference here?

The immediate parent of this commit is 3e53d58bba13 ("net/rds: pin the
connection across RDMA-CM event handling"), which touches net/rds/ib_cm.c,
net/rds/rdma_transport.c and net/rds/rds.h (adding
rds_conn_get_unless_zero()) and does not mention t_conn_count.

t_conn_count and its comment in struct rds_transport were added six patches
earlier, by 45c2c8294f3d ("net/rds: wait for connections to be freed on
transport unload"):

    Count each transport's live connections in t_conn_count (incremented
    when a connection is published in __rds_conn_create(), decremented as
    the last step of rds_conn_destroy_fini()) [...]

whose porting note also says "t_conn_count did not exist upstream and is
introduced here".

The rest of the sentence, that the increments and decrements sit exactly
where rds_conn_count's did, matches the code.  Would it be clearer to name
45c2c8294f3d ("net/rds: wait for connections to be freed on transport
unload") explicitly, or to say "an earlier patch in this series"?

-- 
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260914033719.138057-1-achender%40kernel.org