From: patchwork-bot+netdevbpf@kernel.org
To: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: netdev@vger.kernel.org, jiri@resnulli.us, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
horms@kernel.org, alexandre.ferrieux@gmail.com,
stable@vger.kernel.org, sashiko-bot@kernel.org,
victor@mojatatu.com, hybris@mojatatu.ai
Subject: Re: [PATCH net 1/2] net/sched: cls_u32: fix manual hash table handle IDR aliasing
Date: Fri, 18 Sep 2026 00:10:05 +0000 [thread overview]
Message-ID: <178969020513.191233.10717761906823039417.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <QDISC-LQFE.v1.20260911041746.1@mojatatu.com>
Hello:
This series was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 16 Sep 2026 06:01:14 -0400 you wrote:
> A u32 hash table created with an explicit handle ('tc filter add ...
> handle 801: u32 divisor N') keys its IDR entry on the raw handle, while
> the destroy paths free it under handle2id(handle). The two key domains
> disagree for handles in the 0x800..0xFFF htid range:
> handle2id() folds them back into the auto-allocated id space (1..0x7FF).
>
> A manual table therefore leaves its raw-keyed IDR entry unreachable on
> delete (a permanent leak), and its delete can drop the idr entry of an
> unrelated live auto table. A later auto allocation can then hand out a
> handle that aliases the live manual table; u32_lookup_ht() first-match
> routes lookups and TCA_U32_LINK for that htid to the wrong table.
>
> [...]
Here is the summary with links:
- [net,1/2] net/sched: cls_u32: fix manual hash table handle IDR aliasing
https://git.kernel.org/netdev/net/c/0a5f5d9e94de
- [net,2/2] selftests/tc-testing: add u32 manual table handle IDR tests
https://git.kernel.org/netdev/net/c/960ab631f3d8
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2026-09-18 0:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-16 10:01 [PATCH net 1/2] net/sched: cls_u32: fix manual hash table handle IDR aliasing Jamal Hadi Salim
2026-09-16 10:01 ` [PATCH net 2/2] selftests/tc-testing: add u32 manual table handle IDR tests Jamal Hadi Salim
2026-09-17 12:08 ` Simon Horman
2026-09-17 12:08 ` [PATCH net 1/2] net/sched: cls_u32: fix manual hash table handle IDR aliasing Simon Horman
2026-09-18 5:37 ` Alexandre Ferrieux
2026-09-18 8:22 ` Jamal Hadi Salim
2026-09-18 9:34 ` Alexandre Ferrieux
2026-09-18 0:10 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178969020513.191233.10717761906823039417.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=alexandre.ferrieux@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=hybris@mojatatu.ai \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sashiko-bot@kernel.org \
--cc=stable@vger.kernel.org \
--cc=victor@mojatatu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox