From: patchwork-bot+netdevbpf@kernel.org
To: Eric Dumazet <edumazet@google.com>
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
horms@kernel.org, netdev@vger.kernel.org, eric.dumazet@gmail.com,
jamesburton@meta.com, stable@vger.kernel.org, security@1seal.org,
tung.quang.nguyen@est.tech, jmaloy@redhat.com
Subject: Re: [PATCH net] tipc: reject invalid and unexpected GRP_ACK_MSG to prevent bc_ackers underflow
Date: Fri, 18 Sep 2026 22:50:11 +0000 [thread overview]
Message-ID: <178977181170.1178488.789081349546153625.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20260913044233.193927-1-edumazet@google.com>
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Sun, 13 Sep 2026 04:42:33 +0000 you wrote:
> Commit 48a5fe38772b ("tipc: fix bc_ackers underflow on duplicate
> GRP_ACK_MSG") rejected duplicate/stale ACKs in tipc_group_proto_rcv()
> by returning early when less_eq(acked, m->bc_acked).
>
> However, that check remains incomplete in two ways:
>
> 1. When grp->bc_ackers is zero (e.g. on a quiet group, when replicast
> ACKs were not requested, or after all expected members have already
> acknowledged), an unexpected GRP_ACK_MSG with acked > m->bc_acked
> passes less_eq() and unconditionally decrements grp->bc_ackers.
> Because bc_ackers is a u16, this wraps to 65535, causing
> tipc_group_bc_cong() to permanently report congestion and blocking
> all future group broadcasts on the socket.
>
> [...]
Here is the summary with links:
- [net] tipc: reject invalid and unexpected GRP_ACK_MSG to prevent bc_ackers underflow
https://git.kernel.org/netdev/net/c/99cc2a62e07a
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2026-09-18 22:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-13 4:42 [PATCH net] tipc: reject invalid and unexpected GRP_ACK_MSG to prevent bc_ackers underflow Eric Dumazet
2026-09-14 4:52 ` netdev-bot+sashiko
2026-09-17 8:09 ` Paolo Abeni
2026-09-18 22:50 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178977181170.1178488.789081349546153625.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=horms@kernel.org \
--cc=jamesburton@meta.com \
--cc=jmaloy@redhat.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=security@1seal.org \
--cc=stable@vger.kernel.org \
--cc=tung.quang.nguyen@est.tech \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox