From: Jijie Shao <shaojijie@huawei.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: <shaojijie@huawei.com>, <davem@davemloft.net>,
<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
<andrew+netdev@lunn.ch>, <horms@kernel.org>,
<Frank.Sae@motor-comm.com>, <hkallweit1@gmail.com>,
<linux@armlinux.org.uk>, <shenjian15@huawei.com>,
<liuyonglong@huawei.com>, <chenhao418@huawei.com>,
<jonathan.cameron@huawei.com>, <salil.mehta@huawei.com>,
<shiyongbang@huawei.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RFC net-next 2/6] net: phy: add support to set default rules
Date: Thu, 8 Jan 2026 15:00:43 +0800 [thread overview]
Message-ID: <178a0dc6-438b-4f6f-9cf3-0fb36f7953b3@huawei.com> (raw)
In-Reply-To: <970a1e2d-c1b1-4b96-9e8e-71aea6b6dc44@lunn.ch>
on 2026/1/7 21:09, Andrew Lunn wrote:
> On Thu, Dec 18, 2025 at 09:35:44AM +0800, Jijie Shao wrote:
>> on 2025/12/17 21:53, Andrew Lunn wrote:
>>>> Some of our boards have only one LED, and we want to indicate both
>>>> link and active(TX and RX) status simultaneously.
>>> Configuration is generally policy, which is normally done in
>>> userspace. I would suggest a udev rule.
>>>
>>> Andrew
>> Yes, the PHY LED framework supports configuration from user space,
>> allowing users to configure their preferred policies according to their own requirements.
>> I believe this is the original intention of the LED framework.
>>
>> However, we cannot require users to actively configure policies,
>> nor can we restrict the types of OS versions they use.
>> Therefore, I personally think that the driver should still provide a reasonable default policy
>> to ensure that the LED behavior meets the needs of most scenarios.
> As i said, DT describes hardware, the fact there is an LED, what bus
> it is on, colour etc, is describing hardware. How you blink it is
> policy, so i expect the DT Maintainers will push back on putting
> policy into DT.
>
> So i think your best way forwards is as Russell suggests, some form of
> firmware sets the LED before Linux takes control of it. Or udev.
>
> Andrew
Yes, at present, this seems to be the only solution.
Recently, I have also been developing a UEFI driver for PXE,
which might be a solution.
However, there is no way to handle the issue with another patch;
I cannot directly modify the ACPI table (a risky operation).
Thanks,
Jijie Shao
next prev parent reply other threads:[~2026-01-08 7:01 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-15 12:56 [PATCH RFC net-next 0/6] Support PHY LED for hibmcge driver Jijie Shao
2025-12-15 12:57 ` [PATCH RFC net-next 1/6] net: phy: change of_phy_leds() to fwnode_phy_leds() Jijie Shao
2025-12-17 10:37 ` Jonathan Cameron
2025-12-17 13:18 ` Jijie Shao
2025-12-15 12:57 ` [PATCH RFC net-next 2/6] net: phy: add support to set default rules Jijie Shao
2025-12-16 7:09 ` Andrew Lunn
2025-12-17 12:54 ` Jijie Shao
2025-12-17 13:53 ` Andrew Lunn
2025-12-18 1:35 ` Jijie Shao
2025-12-18 10:12 ` Andrew Lunn
2026-01-07 9:40 ` Jijie Shao
2026-01-07 13:09 ` Andrew Lunn
2026-01-08 7:00 ` Jijie Shao [this message]
2026-01-08 14:31 ` Andrew Lunn
2026-01-02 11:26 ` Russell King (Oracle)
2026-01-07 9:43 ` Jijie Shao
2026-01-07 9:50 ` Russell King (Oracle)
2026-01-07 10:12 ` Jijie Shao
2025-12-15 12:57 ` [PATCH RFC net-next 3/6] net: hibmcge: create a software node for phy_led Jijie Shao
2025-12-16 7:17 ` Andrew Lunn
2025-12-17 12:57 ` Jijie Shao
2026-01-07 10:09 ` Jijie Shao
2026-01-07 13:04 ` Andrew Lunn
2026-01-08 6:57 ` Jijie Shao
2026-01-08 13:59 ` Andrew Lunn
2025-12-15 12:57 ` [PATCH RFC net-next 4/6] net: hibmcge: support get phy_leds_reg from spec register Jijie Shao
2025-12-16 7:19 ` Andrew Lunn
2025-12-17 13:02 ` Jijie Shao
2025-12-15 12:57 ` [PATCH RFC net-next 5/6] net: hibmcge: support get phy device from apci Jijie Shao
2025-12-15 12:57 ` [PATCH RFC net-next 6/6] net: phy: motorcomm: fix duplex setting error for phy leds Jijie Shao
2025-12-16 7:21 ` Andrew Lunn
2025-12-17 13:05 ` Jijie Shao
2025-12-17 13:49 ` Andrew Lunn
2025-12-18 1:39 ` Jijie Shao
2025-12-15 14:46 ` [PATCH RFC net-next 0/6] Support PHY LED for hibmcge driver Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178a0dc6-438b-4f6f-9cf3-0fb36f7953b3@huawei.com \
--to=shaojijie@huawei.com \
--cc=Frank.Sae@motor-comm.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=chenhao418@huawei.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=jonathan.cameron@huawei.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=liuyonglong@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=salil.mehta@huawei.com \
--cc=shenjian15@huawei.com \
--cc=shiyongbang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox