From: Jens Axboe <axboe@kernel.dk>
To: lollipopkit <a@lolli.tech>
Cc: Pavel Begunkov <asml.silence@gmail.com>,
Willem de Bruijn <willemb@google.com>,
io-uring@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] io_uring/cmd_net: end TX_TIMESTAMP multishot when the CQ is full
Date: Mon, 28 Sep 2026 08:31:21 -0600 [thread overview]
Message-ID: <179060588158.984285.6234217255544312653.b4-ty@b4> (raw)
In-Reply-To: <20260927074206.65427-1-a@lolli.tech>
On Sun, 27 Sep 2026 15:42:06 +0800, lollipopkit wrote:
> SOCKET_URING_OP_TX_TIMESTAMP arms an EPOLLERR apoll multishot and, on
> each error queue edge, posts one 32 byte aux CQE per timestamp skb. Aux
> CQEs have no overflow backing, so io_uring_cmd_post_mshot_cqe32() fails
> once the CQ ring is full. The loop then stops, splices the unprocessed
> skbs back onto sk_error_queue and returns -EAGAIN.
>
> -EAGAIN is IOU_RETRY, so the request goes idle until the next poll
> event. io_arm_apoll() forces EPOLLET and draining the CQ does not re-run
> the command, so the spliced-back timestamps stay queued until an
> unrelated later timestamp produces a new edge.
>
> [...]
Applied, thanks!
[1/1] io_uring/cmd_net: end TX_TIMESTAMP multishot when the CQ is full
commit: 3a3d93070c5ec8b8049d57025987ba313420bda9
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2026-09-28 14:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-27 7:42 [PATCH] io_uring/cmd_net: end TX_TIMESTAMP multishot when the CQ is full lollipopkit
2026-09-27 19:16 ` Pavel Begunkov
2026-09-28 14:31 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179060588158.984285.6234217255544312653.b4-ty@b4 \
--to=axboe@kernel.dk \
--cc=a@lolli.tech \
--cc=asml.silence@gmail.com \
--cc=io-uring@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox