Re: [PATCH net v3 1/2] sctp: hold shkey across socket migration

[netdev-bot+sashiko@kernel.org]

Thank you for your contribution! Sashiko AI review found more severe
issue(s) in other patches of this series. This mail is only an FYI, in case
you want to address the nit picks below when you respin.

Low priority / nit picks for your consideration:

- [Low] The commit author, David Lee <david.lee@trailofbits.com>, has no
  Signed-off-by line.

--

sctp: hold shkey across socket migration

sctp_sock_migrate() orphans queued tx chunks before moving the association
to the new socket. skb_orphan() calls sctp_wfree(), which can drop the last
reference on chunk->shkey before sctp_set_owner_w() uses it again. This
patch takes a temporary shkey reference in sctp_clear_owner_w() and drops
it in a new sctp_set_owner_w_migrate() helper, after the new owner has
taken its own reference.

> Fixes: 1b1e0bc99474 ("sctp: add refcnt support for sh_key")
> Assisted-by: Codex:gpt-5.6-sol gpt-5.5-cyber
> Signed-off-by: Kyle Zeng <kylebot@openai.com>
> Acked-by: Xin Long <lucien.xin@gmail.com>

[Severity: Low]
This isn't a bug, but is there a Signed-off-by missing for the patch
author?

The Author: line is David Lee <david.lee@trailofbits.com>. The only
Signed-off-by is from Kyle Zeng <kylebot@openai.com>, and there is no
Co-developed-by tag.

The original submission for this patch seems to have come from
david.lee@trailofbits.com. That means the submitter has not signed off
either.

Documentation/process/submitting-patches.rst requires a DCO sign-off
from the author. checkpatch.pl reports this case as "Missing
Signed-off-by: line by nominal patch author".

Which of these is the intended attribution?

  - Kyle Zeng is the author. The patch would then need a From: Kyle Zeng
    line and a sign-off from the submitter.

  - David Lee is the author. He would then need to add his own
    Signed-off-by, plus a Co-developed-by for Kyle Zeng if he co-wrote
    the patch.

The next patch in the series, "sctp: re-point retained control chunks
on association migration", has the same trailers.

-- 
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260926100359.78731-1-juny24602%40gmail.com