Re: [PATCH net] net/sched: em_text: reject unterminated algo before autoload

[patchwork-bot+netdevbpf@kernel.org]

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Wed, 30 Sep 2026 03:31:02 -0400 you wrote:
> This is a follow-up to commit 9c572a83037a ("net/sched: fix potential
> stack infoleak in em_text_dump()"), which zero-initialised the dump-side
> struct. Sashiko pointed at a pre-existing bug that exposed the change-side
> input-validation gap open.
> 
> em_text_change() casts the raw netlink attribute payload to struct
> tcf_em_text and passes conf->algo, a 16-byte array with no enforced NUL
> terminator, to textsearch_prepare().  On the TS_AUTOLOAD retry
> textsearch_prepare() calls request_module("ts_%s", algo); vsnprintf()
> walks %s until it finds a NUL, so an algo[] with no NUL reads past the
> array into the adjacent struct fields and payload and feeds those bytes
> to the usermode helper command line.  This is an out-of-bounds read and
> a kernel memory disclosure.
> 
> [...]

Here is the summary with links:
  - [net] net/sched: em_text: reject unterminated algo before autoload
    https://git.kernel.org/netdev/net/c/c9728fcf2e7f

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html