Re: [PATCH net-next v8 04/13] net/rds: guard every work-requeueing site with rds_destroy_pending()

[netdev-bot+sashiko@kernel.org]

Thank you for your contribution! Sashiko AI review found more severe
issue(s) in other patches of this series. This mail is only an FYI, in case
you want to address the nit picks below when you respin.

Low priority / nit picks for your consideration:

- [Low] The commit message of "net/rds: guard every work-requeueing site
  with rds_destroy_pending()" has no blank line between the last…

--

net/rds: guard every work-requeueing site with rds_destroy_pending()

This commit adds the rcu_read_lock() + rds_destroy_pending() guard to five
RDS sites that can re-arm path works: the IB send completion and credit
paths, the IB recv refill, the TCP accept path, and the multipath reconnect
in rds_sendmsg(). It prepares for a following patch that adds a
per-connection term to the predicate.

> With the predicate as it stands the guards cover the netns teardown and
> module unload cases; the following patch extends it to the destroy of a
> single connection.
> Assisted-by: Claude-Code:claude-fable-5
> Signed-off-by: Allison Henderson <achender@kernel.org>

[Severity: Low]
This isn't a bug, but there is no blank line between the last paragraph of
the body and the trailers. "single connection." is followed directly by the
Assisted-by: and Signed-off-by: lines.

git interpret-trailers and b4 treat the last paragraph as the trailer block.
In that paragraph, 2 of the 5 lines are trailers, which is over git's 25%
threshold. So the prose lines get counted as part of the trailer block too,
and any tags added later (Reviewed-by:, Link:, Cc: stable) would be appended
to that mixed paragraph.

Could a blank line be added before "Assisted-by:" when this is respun?

-- 
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261003163215.250253-1-achender%40kernel.org