Re: [PATCH net-next v16 13/15] quic: add timer management

[netdev-bot+sashiko@kernel.org]

Thank you for your contribution! Sashiko AI review found more severe
issue(s) in other patches of this series. This mail is only an FYI, in case
you want to address the nit picks below when you respin.

Low priority / nit picks for your consideration:

- [Low] The Signed-off-by chain of commit "quic: add timer management"
  does not follow Documentation/process/submitting-patches.rst.

--

quic: add timer management

This patch adds struct quic_timer to manage the five QUIC timers: loss
detection, delayed ACK, path validation, PMTU probing and pacing. It
provides common reset, start and stop helpers. Expirations that happen
while the socket is owned by the user are deferred and handled in
quic_release_cb().

> Signed-off-by: Tyler Fanelli <tfanelli@redhat.com>
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
> Acked-by: Paolo Abeni <pabeni@redhat.com>

[Severity: Low]
This isn't a bug, but is the Signed-off-by chain in the right order?

The author is Xin Long, but the first Signed-off-by is Tyler Fanelli's.
There is no Co-developed-by: tag either.

Documentation/process/submitting-patches.rst says:

  SoB chains should reflect the **real** route a patch took
  as it was propagated to the maintainers and ultimately to Linus, with
  the first SoB entry signalling primary authorship of a single author.

It also says:

  Since
  Co-developed-by: denotes authorship, every Co-developed-by: must be
  immediately followed by a Signed-off-by: of the associated co-author.

If Tyler Fanelli co-developed this patch, should this line go directly
before his Signed-off-by?

  Co-developed-by: Tyler Fanelli <tfanelli@redhat.com>

If he didn't, his Signed-off-by is in the wrong place.

Other patches in the series have the same pattern:

- "quic: add path management" (Tyler Fanelli)
- "quic: provide quic.h header files for kernel and userspace" (Tyler
  Fanelli, Stefan Metzmacher, Thomas Dreibholz)
- "quic: add crypto key derivation and installation" (Pengtao He,
  Moritz Buhl)
- "net: build socket infrastructure for QUIC protocol" (Pengtao He)

-- 
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/cover.1791227050.git.lucien.xin%40gmail.com