From: patchwork-bot+netdevbpf@kernel.org
To: Joas Antonio dos Santos <joasantonio108@gmail.com>
Cc: paul@paul-moore.com, davem@davemloft.net, edumazet@kernel.org,
kuba@kernel.org, pabeni@redhat.com, horms@kernel.org,
netdev@vger.kernel.org, linux-security-module@vger.kernel.org
Subject: Re: [PATCH net-next] calipso: hash the cache key, not the option start, in calipso_cache_add()
Date: Tue, 13 Oct 2026 10:10:04 +0000 [thread overview]
Message-ID: <179188620452.191181.12068195457732970673.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <179138670045.80227.16155454353416856947@gmail.com>
Hello:
This patch was applied to netdev/net-next.git (main)
by Paolo Abeni <pabeni@redhat.com>:
On Wed, 07 Oct 2026 12:25:00 -0300 you wrote:
> calipso_cache_add() stores calipso_ptr + 2 as the cache key, but
> computes entry->hash over calipso_ptr, i.e. starting two bytes earlier
> at the option type and length. calipso_opt_getattr() looks entries up
> with calipso_cache_check(calipso + 2, calipso[1], ...), which hashes the
> key itself.
>
> The two hashes only match on a jhash collision, so the CALIPSO label
> cache never hits and every labelled packet takes the full DOI lookup and
> category conversion path. The memcmp() on the key keeps lookups
> correct, so this is a performance bug only.
>
> [...]
Here is the summary with links:
- [net-next] calipso: hash the cache key, not the option start, in calipso_cache_add()
https://git.kernel.org/netdev/net-next/c/d538cc3ec0bc
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
next prev parent reply other threads:[~2026-10-13 10:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-07 15:25 [PATCH net-next] calipso: hash the cache key, not the option start, in calipso_cache_add() Joas Antonio dos Santos
2026-10-09 11:42 ` Daniel Machon
2026-10-13 10:10 ` patchwork-bot+netdevbpf [this message]
2026-10-13 20:03 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179188620452.191181.12068195457732970673.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=horms@kernel.org \
--cc=joasantonio108@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=paul@paul-moore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox