Re: [PATCH net-next v3 2/8] net: xilinx: tsn: add TSN endpoint wrapper driver

[netdev-bot+sashiko@kernel.org]

Thank you for your contribution! Sashiko AI review found more severe
issue(s) in other patches of this series. This mail is only an FYI, in case
you want to address the nit picks below when you respin.

Low priority / nit picks for your consideration:

- [Low] The XILINX_TSN Kconfig help text says "The three-port switch is
  supported by the companion DSA driver." That driver does not exist in…

--

net: xilinx: tsn: add TSN endpoint wrapper driver

This adds a thin platform driver for the AMD/Xilinx TSN Endpoint
Ethernet MAC IP node. It turns on the six IP-wide clocks and then calls
devm_of_platform_populate(), so each sub-node can bind to its own
driver.

> diff --git a/drivers/net/ethernet/xilinx/tsn/Kconfig b/drivers/net/ethernet/xilinx/tsn/Kconfig
> new file mode 100644
> index 0000000000000..b8939d8a92ef7
> --- /dev/null
> +++ b/drivers/net/ethernet/xilinx/tsn/Kconfig
> @@ -0,0 +1,15 @@

[ ... ]

> +config XILINX_TSN
> +	tristate "Xilinx TSN Ethernet driver"
> +	depends on OF_ADDRESS
> +	help
> +	  This driver supports the AMD/Xilinx Time-Sensitive Networking
> +	  (TSN) Endpoint Ethernet MAC IP. It provides the wrapper device
> +	  and the endpoint MAC that connects the IP to the host CPU. The
> +	  three-port switch is supported by the companion DSA driver.

[Severity: Low]
Which DSA driver is this sentence about? I couldn't find one in the
tree, either at this commit or at the end of the series.

The binding in this series defines the "xlnx,tsn-switch" compatible for
the switch@ sub-node, and nothing under drivers/ matches it.
tsn_ip_probe() calls devm_of_platform_populate(), which creates a
platform device for switch@, but no driver ever binds to it.

The v2 changelog says the help text was reworded so it no longer points
at "a symbol that does not exist yet at this patch". The new wording
still names a driver that isn't in the tree and has no Kconfig symbol.

Could this sentence be dropped or reworded until the switch driver is
posted?

Two other claims do become true later in the series: "endpoint MAC" in
the help text, and "bind each sub-node to its own driver" in the commit
message. That happens when "net: xilinx: tsn: add endpoint MAC driver
skeleton" adds xlnx_tsn_ep_driver to tsn_drivers[]. Only the DSA driver
reference is still wrong once the whole series is applied.

-- 
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261016-patches_v2_external-v3-0-e33d3960ca1e%40amd.com