From: patchwork-bot+netdevbpf@kernel.org
To: Tristan Madani <tristmd@gmail.com>
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@kernel.org,
kuba@kernel.org, pabeni@redhat.com, qingfang.deng@linux.dev,
linux-ppp@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
tristan@talencesecurity.com
Subject: Re: [PATCH net] ppp: fix stale pointer access after pskb_may_pull in ppp_ccp_peek
Date: Wed, 28 Oct 2026 10:02:13 +0000 [thread overview]
Message-ID: <179318173377.622019.1649392373971211231.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20261023195309.3527129-1-tristmd@gmail.com>
Hello:
This patch was applied to netdev/net.git (main)
by Dave Miller <davem@davem-thinkpadp1gen8.ibmlond.csb>:
On Fri, 23 Oct 2026 19:53:09 +0000 you wrote:
> From: Tristan Madani <tristan@talencesecurity.com>
>
> ppp_ccp_peek() caches a pointer to skb->data in dp after the first
> pskb_may_pull(), then uses dp after a second pskb_may_pull(skb, len + 2)
> in the CCP_CONFACK handler. If the second pull triggers
> pskb_expand_head() due to a cloned skb or frag linearization,
> skb->head is freed and reallocated, leaving dp stale.
>
> [...]
Here is the summary with links:
- [net] ppp: fix stale pointer access after pskb_may_pull in ppp_ccp_peek
https://git.kernel.org/netdev/net/c/1e860f42f41c
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2026-10-28 10:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-23 19:53 [PATCH net] ppp: fix stale pointer access after pskb_may_pull in ppp_ccp_peek Tristan Madani
2026-10-23 19:55 ` netdev-bot+sinfo
2026-10-28 10:02 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179318173377.622019.1649392373971211231.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ppp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=qingfang.deng@linux.dev \
--cc=stable@vger.kernel.org \
--cc=tristan@talencesecurity.com \
--cc=tristmd@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox