From: Joas Antonio dos Santos <joasantonio108@gmail.com>
To: "Ömer Mete Kaya" <omermetekaya0@gmail.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
Mina Almasry <almasrymina@google.com>,
Hangbin Liu <hangbin.liu@linux.dev>,
Andrew Lunn <andrew+netdev@lunn.ch>,
David S. Miller <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Jiri Pirko <jiri@resnulli.us>,
syzbot+88435e204734072bf39a@syzkaller.appspotmail.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2] netdevsim: reject port addition and clean up ports after a failed reload
Date: Fri, 30 Oct 2026 14:23:45 -0300 [thread overview]
Message-ID: <179338102577.65907.6165293008000000698@gmail.com> (raw)
In-Reply-To: <20261030001444.289973-1-omermetekaya0@gmail.com>
On Fri, Oct 30, 2026, Ömer Mete Kaya wrote:
> nsim_drv_port_add() does not check devlink_is_reload_failed(), so ports
> can be added via new_port after a failed reload.
I sent a fix for the same syzbot report a bit earlier, which only
deleted the leftover ports in nsim_dev_reload_destroy(). Rejecting
new_port once the reload has failed is the better fix, so please take
this one and drop mine.
I tested this patch on net/main (94cea342e891) on arm64 QEMU with KASAN,
running the syzbot C reproducer. Without a fix it hits the WARNING in
bpf_offload_dev_destroy() and then a slab-use-after-free in
devlink_bus_name() through the leftover netdev; with this patch there
is no warning or KASAN report in 3 runs.
Tested-by: Joas Antonio dos Santos <joasantonio108@gmail.com>
prev parent reply other threads:[~2026-10-30 17:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-30 0:13 [PATCH net-next v2] netdevsim: reject port addition and clean up ports after a failed reload Ömer Mete Kaya
2026-10-30 0:18 ` Mina Almasry
2026-10-30 0:28 ` Ömer Mete Kaya
2026-10-30 2:05 ` Hangbin Liu
2026-10-30 6:42 ` Mina Almasry
2026-10-30 7:26 ` Hangbin Liu
2026-10-30 17:23 ` Joas Antonio dos Santos [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179338102577.65907.6165293008000000698@gmail.com \
--to=joasantonio108@gmail.com \
--cc=almasrymina@google.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hangbin.liu@linux.dev \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=omermetekaya0@gmail.com \
--cc=pabeni@redhat.com \
--cc=syzbot+88435e204734072bf39a@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox