From: patchwork-bot+netdevbpf@kernel.org
To: Fernando Fernandez Mancera <fmancera@suse.de>
Cc: netdev@vger.kernel.org, linux-s390@vger.kernel.org,
linux-rdma@vger.kernel.org, jaka@linux.ibm.com, horms@kernel.org,
pabeni@redhat.com, kuba@kernel.org, edumazet@kernel.org,
davem@davemloft.net, guwen@linux.alibaba.com,
tonylu@linux.alibaba.com, mjambigi@linux.ibm.com,
sidraya@linux.ibm.com, dust.li@linux.alibaba.com,
alibuda@linux.alibaba.com
Subject: Re: [PATCH net] net/smc: fix limit_smc_hs sysctl on big-endian architecture
Date: Sat, 31 Oct 2026 02:10:06 +0000 [thread overview]
Message-ID: <179341260654.1900554.4006093969665591085.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20261028225350.3753-1-fmancera@suse.de>
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 28 Oct 2026 23:53:50 +0100 you wrote:
> net->smc.limit_smc_hs is a bool, but its sysctl entry uses
> proc_dointvec_minmax() with .maxlen = sizeof(int), so the handler
> accesses four bytes at the address of a one-byte field.
>
> On little-endian this works with the extra bytes being written in struct
> padding. On big-endian (tested on s390x) the bool sits at the most
> significant byte of the int therefore the bool stays false and the "1"
> goes into padding. The sysctl reads back 1 but SMC sockets created
> afterwards see limit_smc_hs as disabled.
>
> [...]
Here is the summary with links:
- [net] net/smc: fix limit_smc_hs sysctl on big-endian architecture
https://git.kernel.org/netdev/net/c/162cf592b577
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2026-10-31 2:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 22:53 [PATCH net] net/smc: fix limit_smc_hs sysctl on big-endian architecture Fernando Fernandez Mancera
2026-10-31 2:10 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179341260654.1900554.4006093969665591085.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=alibuda@linux.alibaba.com \
--cc=davem@davemloft.net \
--cc=dust.li@linux.alibaba.com \
--cc=edumazet@kernel.org \
--cc=fmancera@suse.de \
--cc=guwen@linux.alibaba.com \
--cc=horms@kernel.org \
--cc=jaka@linux.ibm.com \
--cc=kuba@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mjambigi@linux.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sidraya@linux.ibm.com \
--cc=tonylu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox