Re: [PATCH net-next v18 02/15] net: build socket infrastructure for QUIC protocol

[netdev-bot+sashiko@kernel.org]

Thank you for your contribution! Sashiko AI review found more severe
issue(s) in other patches of this series. This mail is only an FYI, in case
you want to address the nit picks below when you respin.

Low priority / nit picks for your consideration:

- [Low] The tag block of commit "net: build socket infrastructure for
  QUIC protocol" reads 'Signed-off-by: Xin Long <lucien.xin@gmail.com>',…

--

net: build socket infrastructure for QUIC protocol

This patch adds the base socket infrastructure for QUIC: Kconfig and
Makefile integration, proto and proto_ops registration for IPv4 and IPv6,
per-net SNMP counters in procfs, and sysctl knobs for memory limits. Most
protocol operations are placeholders that later patches in the series fill
in.

> Signed-off-by: Xin Long <lucien.xin@gmail.com>
> Signed-off-by: Pengtao He <hepengtao@xiaomi.com>
> Acked-by: Paolo Abeni <pabeni@redhat.com>

[Severity: Low]
This isn't a bug, but are the sign-off tags in the right order?

Documentation/process/submitting-patches.rst gives two rules here:

  - A Co-developed-by tag must come directly before each co-author's
    Signed-off-by.

  - "the last Signed-off-by: must always be that of the developer
    submitting the patch."

Xin Long is the author, and he also appears to be the one submitting the
series. The last patch, "quic: add packet parser base", has only his
Signed-off-by.

If Pengtao He co-developed this patch, the tags should look like this:

  Co-developed-by: Pengtao He <hepengtao@xiaomi.com>
  Signed-off-by: Pengtao He <hepengtao@xiaomi.com>
  Signed-off-by: Xin Long <lucien.xin@gmail.com>

If he only handled the patch, the current chain does not match the route
the patch actually took.

Other patches in the series follow the same pattern, for example "quic:
add crypto key derivation and installation" and "quic: provide quic.h
header files for kernel and userspace".

-- 
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/cover.1794241654.git.lucien.xin%40gmail.com