Re: [PATCH net-next v4 2/5] net: devmem: charge the frag length to TX skb truesize

[netdev-bot+sashiko@kernel.org]

Thank you for your contribution! Sashiko AI review found more severe
issue(s) in other patches of this series. This mail is only an FYI, in case
you want to address the nit picks below when you respin.

Low priority / nit picks for your consideration:

- [Low] The commit's author identity doesn't match its Signed-off-by
  identity.

--

net: devmem: charge the frag length to TX skb truesize

The devmem TX path in zerocopy_fill_skb_from_devmem() used to charge
PAGE_SIZE (the net_iov size) to skb->truesize for each frag. This patch
charges the frag length instead. With TX net_iovs about to grow to 2MB,
charging the net_iov size would overcharge the send buffer, and the frag
length also matches what TCP uncharges.

> Author: Stanislav Fomichev <sdf.kernel@gmail.com>
> [ ... ]
> Signed-off-by: Stanislav Fomichev <sdf@fomichev.me>

[Severity: Low]
This isn't a bug, but the author address and the Signed-off-by address
are different. The author is sdf.kernel@gmail.com, and the only sign-off
from the author is sdf@fomichev.me.

checkpatch.pl reports this as FROM_SIGN_OFF_MISMATCH ("From:/Signed-off-by:
email address mismatch"). The other patches in the series have the same
mismatch, from "bnxt_en: let the stack segment GSO skbs with too many
frags" through "selftests: drv-net: devmem: TX from a hugepage-backed
dmabuf".

When resending, could you add an in-body "From: Stanislav Fomichev
<sdf@fomichev.me>" line, or a Signed-off-by for the gmail address?

-- 
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261111224740.2744522-1-sdf%40fomichev.me