Re: [PATCH net-next v5 04/15] ice: add helpers for Global RSS LUT alloc, free, vsi_update

[netdev-bot+sashiko@kernel.org]

Thank you for your contribution! Sashiko AI review found more severe
issue(s) in other patches of this series. This mail is only an FYI, in case
you want to address the nit picks below when you respin.

Low priority / nit picks for your consideration:

- [Low] The comment on the new `global_lut_id` field in `struct ice_vsi`
  (drivers/net/ethernet/intel/ice/ice.h) says it is "valid when lut_type…

--

ice: add helpers for Global RSS LUT alloc, free, vsi_update

This commit adds admin queue helpers to allocate and free RSS Global LUTs.
It also programs the Global LUT ID and the RSS LUT type into the VSI
context. It adds a global_lut_id field to struct ice_vsi to hold the
allocated LUT ID.

> diff --git a/drivers/net/ethernet/intel/ice/ice.h b/drivers/net/ethernet/intel/ice/ice.h
> index 432da05c48c08..89a2bdbecf609 100644
> --- a/drivers/net/ethernet/intel/ice/ice.h
> +++ b/drivers/net/ethernet/intel/ice/ice.h
> @@ -367,6 +367,7 @@ struct ice_vsi {
>  	u8 *rss_hkey_user;	/* User configured hash keys */
>  	u8 *rss_lut_user;	/* User configured lookup table entries */
>  	u8 rss_lut_type;	/* used to configure Get/Set RSS LUT AQ call */
> +	u8 global_lut_id;       /* valid when lut_type == GLOBAL_LUT */

[Severity: Low]
This isn't a bug, but the comment refers to identifiers that don't exist
here. The struct member is rss_lut_type, not lut_type. The enum constant
is ICE_LUT_GLOBAL, not GLOBAL_LUT.

The only reader of this field, ice_set_rss_vsi_ctx(), checks:

	if (vsi->rss_lut_type == ICE_LUT_GLOBAL)
		global_lut_id = vsi->global_lut_id;

Could the comment be changed to say "valid when rss_lut_type ==
ICE_LUT_GLOBAL"? The same wording is still there at the end of the
series.

[ ... ]

-- 
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261110141534.95614-1-przemyslaw.kitszel%40intel.com