Re: [PATCH net-next v02 3/5] hinic3: fix some checkpatchs.

[netdev-bot+sashiko@kernel.org]

Thank you for your contribution! Sashiko AI review found more severe
issue(s) in other patches of this series. This mail is only an FYI, in case
you want to address the nit picks below when you respin.

Low priority / nit picks for your consideration:

- [Low] The commit "hinic3: fix some checkpatchs." changes only style,
  but it carries `Fixes: 73f37a7e1993 ("hinic3: Queue pair resource…
- [Low] The commit message is only the subject "hinic3: fix some
  checkpatchs." plus the `Fixes:` tag and sign-offs.

--

hinic3: fix some checkpatchs.

This commit renames the trxq_params parameter to q_params in
hinic3_alloc_channel_resources() and hinic3_free_channel_resources().
It also moves the return type of both functions onto its own line.
Nothing else in the code changes.

> hinic3: fix some checkpatchs.

[Severity: Low]
This isn't a bug, but the commit message has nothing besides the subject
and the tags.

It doesn't say which checkpatch warning is being fixed. The old
continuation lines were about 87 columns wide. Default checkpatch
(max_line_length=100) doesn't flag that, so only an 80 column run would
report them.

It also doesn't mention the trxq_params -> q_params rename, or that the
change has no functional effect.

Could a short description be added? checkpatch itself warns when the
commit description is missing.

> Fixes: 73f37a7e1993 ("hinic3: Queue pair resource initialization")

[Severity: Low]
Is the Fixes: tag appropriate here?

In drivers/net/ethernet/huawei/hinic3/hinic3_netdev_ops.c, the diff
renames trxq_params to q_params. It also re-wraps the signatures of
hinic3_alloc_channel_resources() and hinic3_free_channel_resources().

No expressions, calls, ordering or error paths change. The callers are
untouched, and the generated code should be the same.

Commit 73f37a7e1993 did add these functions, but this patch doesn't fix
a bug in them.

The other patches in this series are fixes aimed at net. Examples are
"hinic3: Solve an stall issue in hinic3_rx_poll()" and "hinic3: Avoid
concurrent updates on 32-bit systems.".

With the tag, could this cosmetic change be taken into net? Could stable
or AUTOSEL then pick it up for every tree that contains 73f37a7e1993?

Would it be better to drop this patch from the fix series, or to resend
it to net-next without the Fixes: tag?

-- 
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/cover.1794371175.git.gongfan1%40huawei.com