Netdev List
 help / color / mirror / Atom feed
From: netdev-bot+sashiko@kernel.org
To: suraj.gupta2@amd.com
Cc: radhey.shyam.pandey@amd.com, andrew+netdev@lunn.ch,
	davem@davemloft.net, edumazet@kernel.org, kuba@kernel.org,
	pabeni@redhat.com, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, michal.simek@amd.com, linux@armlinux.org.uk,
	netdev@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v5 2/6] dt-bindings: net: xlnx,xxv-ethernet: Add Xilinx XXV 10G/25G Ethernet
Date: Mon, 16 Nov 2026 04:12:27 +0000	[thread overview]
Message-ID: <179480234767.3136.1383853926077576761@kernel.org> (raw)
In-Reply-To: <20261114182947.2908628-3-suraj.gupta2@amd.com>

Thank you for your contribution! Sashiko AI review found more severe
issue(s) in other patches of this series. This mail is only an FYI, in case
you want to address the nit picks below when you respin.

Low priority / nit picks for your consideration:

- [Low] Documentation/devicetree/bindings/net/xlnx,xxv-ethernet.yaml
  blocks the inherited properties that conflict with its stated design:…

--

dt-bindings: net: xlnx,xxv-ethernet: Add Xilinx XXV 10G/25G Ethernet

This commit adds a dedicated schema for the Xilinx XXV 10G/25G Ethernet
subsystem, which has an in-core PCS/PMA and uses an external AXI DMA or
MCDMA controller. It requires xlnx,rxmem and adds the optional
xlnx,has-statistics-counters property. It also disallows phy-handle, phy,
phy-device and pcs-handle, and restricts managed to in-band-status.

> diff --git a/Documentation/devicetree/bindings/net/xlnx,xxv-ethernet.yaml b/Documentation/devicetree/bindings/net/xlnx,xxv-ethernet.yaml
> new file mode 100644
> index 0000000000000..caf582c72a8dc
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/xlnx,xxv-ethernet.yaml

[ ... ]

> +  phy-mode:
> +    enum:
> +      - 10gbase-r
> +      - 25gbase-r
> +
> +  # The subsystem has no MDIO bus master and its PCS is in-core, so neither
> +  # an external PHY nor an external PCS can be attached. phy and phy-device
> +  # are the deprecated spellings of phy-handle.
> +  phy-handle: false
> +  phy: false
> +  phy-device: false
> +  pcs-handle: false
> +
> +  managed:
> +    const: in-band-status

[Severity: Low]
Should fixed-link also be set to false here?

fixed-link comes in through the ethernet-controller.yaml $ref in the same
way as the other blocked properties, so unevaluatedProperties: false does
not reject it. ethernet-controller.yaml also does not make fixed-link and
managed mutually exclusive. Its only dependencies entry is pcs-handle-names
requiring pcs-handle.

The commit message and the binding description both say "the link is
always managed in-band". Even so, this schema accepts two configurations
that go against that.

The first is a node with fixed-link alone. In drivers/net/phy/phylink.c,
phylink_parse_mode() checks fixed-link after the in-band default:

	if (pl->config->default_an_inband)
		pl->cfg_link_an_mode = MLO_AN_INBAND;

	dn = fwnode_get_named_child_node(fwnode, "fixed-link");
	if (dn || fwnode_property_present(fwnode, "fixed-link"))
		pl->cfg_link_an_mode = MLO_AN_FIXED;

This overrides the default_an_inband = true that
axienet_xxv_phylink_set_capabilities() sets in the XXV driver patch later
in this series. Carrier would then come from the emulated fixed state, not
from the PCS status that axienet_xxv_pcs_get_state() reads.

The second is a node with fixed-link plus managed = "in-band-status". The
binding allows both properties, but phylink_parse_mode() rejects the
combination:

		if (pl->cfg_link_an_mode == MLO_AN_FIXED) {
			phylink_err(pl,
				    "can't use both fixed-link and in-band-status\n");
			return -EINVAL;
		}

So the device fails to probe from axienet_probe()->phylink_create(), even
though dt_binding_check accepted the node.

Later patches in the series don't change this binding file, so the gap is
still there at the end of the series. Adding "fixed-link: false" next to
the other blocked properties would close it.

-- 
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261114182947.2908628-1-suraj.gupta2%40amd.com

  reply	other threads:[~2026-11-16  4:12 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-14 18:29 [PATCH net-next v5 0/6] net: xilinx: axienet: Add 10G/25G (XXV) ethernet support Suraj Gupta
2026-11-14 18:29 ` [PATCH net-next v5 1/6] net: xilinx: axienet: Introduce axienet_config for MAC-specific ops Suraj Gupta
2026-11-16  4:12   ` netdev-bot+sashiko
2026-11-14 18:29 ` [PATCH net-next v5 2/6] dt-bindings: net: xlnx,xxv-ethernet: Add Xilinx XXV 10G/25G Ethernet Suraj Gupta
2026-11-16  4:12   ` netdev-bot+sashiko [this message]
2026-11-14 18:29 ` [PATCH net-next v5 3/6] net: xilinx: axienet: Propagate device reset failure from ndo_open Suraj Gupta
2026-11-16  4:12   ` netdev-bot+sashiko
2026-11-14 18:29 ` [PATCH net-next v5 4/6] net: xilinx: axienet: Add 10G/25G (XXV) ethernet support Suraj Gupta
2026-11-16  4:12   ` netdev-bot+sashiko
2026-11-14 18:29 ` [PATCH net-next v5 5/6] net: xilinx: axienet: Dispatch statistics through axienet_config ops Suraj Gupta
2026-11-14 18:29 ` [PATCH net-next v5 6/6] net: xilinx: axienet: Add statistics support for XXV ethernet Suraj Gupta
2026-11-16  4:12   ` netdev-bot+sashiko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179480234767.3136.1383853926077576761@kernel.org \
    --to=netdev-bot+sashiko@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=michal.simek@amd.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=radhey.shyam.pandey@amd.com \
    --cc=robh@kernel.org \
    --cc=suraj.gupta2@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox