From: netdev-bot+sashiko@kernel.org
To: linusw@kernel.org
Cc: ulli.kroll@googlemail.com, andrew+netdev@lunn.ch,
davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
mirq-linux@rere.qmqm.pl, mhun512@gmail.com, edumazet@kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next v8 02/19] net: ethernet: cortina: Keep ports bound for shared IRQ
Date: Mon, 16 Nov 2026 14:45:44 +0000 [thread overview]
Message-ID: <179484034429.3136.3425183655553071974@kernel.org> (raw)
In-Reply-To: <20261112-gemini-ethernet-fixes-3-v8-2-f55bd43e02d3@kernel.org>
Thank you for your contribution! Sashiko AI review found 1 potential
issue(s) to consider.
Critical: 0 · High: 1 (2) · Medium: 0 · Low: 0 (1)
If you believe none of the issues are legitimate, please reply to each
issue of Medium severity or higher and explain why the AI is wrong.
If any of them are legitimate and you plan to respin, please let patchwork
know by including "pw-bot: cr" as a separate line at the end of your reply
(one such reply per series is enough).
- [High] In gmac_setup_phy() (drivers/net/ethernet/cortina/gemini.c),
every NULL return from of_phy_find_device() becomes -EPROBE_DEFER.
Pre-existing issues:
- [High] At this commit, geth_resize_freeq() re-enables
SWFQ_EMPTY_INT_BIT even when geth_setup_freeq() fails.
- [High] At this commit, geth_resize_freeq() frees and rebuilds the
shared free queue under RTNL only.
- [Low] The geth_resize_freeq() kernel-doc says it 'gets called at least
once during probe()', but its only callers are gmac_open() and…
--
net: ethernet: cortina: Keep ports bound for shared IRQ
The patch keeps gemini child ports bound in an IRQ-only mode when no PHY
is described, or when PHY setup or netdev registration fails, so the
shared free queue IRQ on port 1 stays available. It looks up referenced
PHYs explicitly and defers probe until they register. It publishes a
port to the parent only once the port is ready, and the port pointers
are protected by RTNL.
> diff --git a/drivers/net/ethernet/cortina/gemini.c b/drivers/net/ethernet/cortina/gemini.c
> index 0b05a15529832..1b959ca853c64 100644
> --- a/drivers/net/ethernet/cortina/gemini.c
> +++ b/drivers/net/ethernet/cortina/gemini.c
[ ... ]
> @@ -359,18 +361,51 @@ static void gmac_adjust_link(struct net_device *netdev)
[ ... ]
> static int gmac_setup_phy(struct net_device *netdev)
> {
[ ... ]
> + } else {
> + phy_np = of_parse_phandle(dev->of_node, "phy-handle", 0);
> + if (!phy_np)
> + return -ENODEV;
> + }
> +
> + phy = of_phy_find_device(phy_np);
> + of_node_put(phy_np);
> if (!phy)
> - return -ENODEV;
> + return -EPROBE_DEFER;
[Severity: High]
Can a NULL return from of_phy_find_device() here be permanent instead
of transient?
Say the MDIO bus has registered, but the PHY at that address never
answered. __of_mdiobus_parse_phys() logs the error, skips the PHY and
still registers the bus:
drivers/net/mdio/of_mdio.c:__of_mdiobus_parse_phys() {
...
if (rc == -ENODEV)
dev_err(&mdio->dev,
"MDIO device at address %d is missing.\n",
addr);
...
}
The same thing happens if the phy-handle target is not a PHY, or if its
bus driver is not built. In all of these cases no phy_device will ever
show up, but gemini_ethernet_port_probe() treats the result as a
deferral:
ret = gmac_setup_phy(netdev);
if (ret) {
dev_err_probe(dev, ret, "PHY init failed\n");
if (ret == -EPROBE_DEFER)
goto unprepare;
goto irq_only;
}
The port then never reaches gemini_port_publish(). That leaves
geth->port0 or geth->port1 NULL and geth->initialized false, and the
sibling's gmac_open()->geth_resize_freeq() returns -ENODEV on every
open:
if (!geth->initialized || !geth->port0 || !geth->port1)
return -ENODEV;
Doesn't this mean a PHY that is described but absent on one port still
disables the working sibling? The commit message says this should no
longer happen ("so an unusable interface does not disable its
sibling").
gemini-ssi1328.dts and gemini-wbd222.dts both use phy-handle on
ethernet-port@1. On those boards, an unpopulated or unresponsive PHY1
would leave no working Ethernet, and the port would stay on the deferred
probe list for good. fw_devlink does not parse phy-handle, so nothing
puts a limit on the deferral.
Could the code tell a not-yet-probed MDIO bus apart from a missing PHY,
for example by checking whether the PHY node's parent bus has
registered?
[ ... ]
> @@ -1051,10 +1086,17 @@ static int geth_resize_freeq(struct gemini_ethernet_port *port)
> u32 en;
> int ret;
>
> + ASSERT_RTNL();
> +
> + /* The software free queue interrupt is routed through port 1. */
> + if (!geth->initialized || !geth->port0 || !geth->port1)
> + return -ENODEV;
> +
[Severity: Low]
This isn't a bug introduced by this patch, but the kernel-doc above
geth_resize_freeq() still says:
* This gets called at least once during probe() so the device queue gets
* "resized" from the hardware defaults.
The only callers are gmac_open() and gmac_set_ringparam(). The doc also
doesn't mention the new ASSERT_RTNL() requirement or the -ENODEV return.
A later patch in the series rewrites it to "This is called when a port
is opened or its RX ring size changes."
[ ... ]
> @@ -1076,7 +1117,7 @@ static int geth_resize_freeq(struct gemini_ethernet_port *port)
> new_order = min(15, ilog2(new_size - 1) + 1);
> dev_dbg(geth->dev, "set shared queue to size %d order %d\n",
> new_size, new_order);
> - if (geth->freeq_order == new_order)
> + if (geth->freeq_ring && geth->freeq_order == new_order)
> return 0;
>
> spin_lock_irqsave(&geth->irq_lock, flags);
[Severity: High]
This is a pre-existing issue and was not introduced by this patch.
Further down in geth_resize_freeq(), SWFQ_EMPTY_INT_BIT is turned back
on even when geth_setup_freeq() fails:
geth->freeq_order = new_order;
ret = geth_setup_freeq(geth);
...
spin_lock_irqsave(&geth->irq_lock, flags);
en |= SWFQ_EMPTY_INT_BIT;
writel(en, geth->base + GLOBAL_INTERRUPT_ENABLE_4_REG);
spin_unlock_irqrestore(&geth->irq_lock, flags);
return ret;
If setup fails, freeq_ring is left NULL while freeq_pages still points
at freed memory. Can gemini_port_irq_thread()->geth_fill_freeq() then
dereference the freed array and call page_ref_add() on stale pages?
This looks like it is addressed later in the series by "net: ethernet:
cortina: Drain free queue IRQ before resize". That commit enables the
source only when setup succeeds, and geth_setup_freeq() and
geth_cleanup_freeq() set freeq_pages and freeq_ring to NULL.
[Severity: High]
This is also a pre-existing issue and not something added by this patch.
In geth_resize_freeq(), only RTNL serializes the queue teardown:
/* Drop the old queue */
if (geth->freeq_ring)
geth_cleanup_freeq(geth);
There is no synchronize_irq() here, and freeq_lock is not held. If
gemini_port_irq_thread() was already woken, could it run
geth_fill_freeq() on the freed freeq_pages and freeq_ring? Could it
then re-arm the source while the queue is being torn down?
irqmask |= readl(geth->base + GLOBAL_INTERRUPT_ENABLE_4_REG);
writel(irqmask, geth->base + GLOBAL_INTERRUPT_ENABLE_4_REG);
The same later commit, "net: ethernet: cortina: Drain free queue IRQ
before resize", wraps the rebuild in disable_irq(geth->port1->irq) and
enable_irq(). That drains both the hard and the threaded handler.
--
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261112-gemini-ethernet-fixes-3-v8-0-f55bd43e02d3%40kernel.org
next prev parent reply other threads:[~2026-11-16 14:45 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 13:30 [PATCH net-next v8 00/19] net: ethernet: cortina: Fix Gemini RX/TX buffer management Linus Walleij
2026-11-12 13:30 ` [PATCH net-next v8 01/19] net: ethernet: cortina: Keep shared free queue parent-owned Linus Walleij
2026-11-12 13:30 ` [PATCH net-next v8 02/19] net: ethernet: cortina: Keep ports bound for shared IRQ Linus Walleij
2026-11-16 14:45 ` netdev-bot+sashiko [this message]
2026-11-12 13:30 ` [PATCH net-next v8 03/19] net: ethernet: cortina: Drain free queue IRQ before resize Linus Walleij
2026-11-12 13:30 ` [PATCH net-next v8 04/19] net: ethernet: cortina: Normalize free queue pointers on rebuild Linus Walleij
2026-11-12 13:30 ` [PATCH net-next v8 05/19] net: ethernet: cortina: Correct free queue DMA mappings Linus Walleij
2026-11-12 13:30 ` [PATCH net-next v8 06/19] net: ethernet: cortina: Index free queue fragments with XArray Linus Walleij
2026-11-16 14:45 ` netdev-bot+sashiko
2026-11-12 13:30 ` [PATCH net-next v8 07/19] net: ethernet: cortina: Preserve in-flight free queue pages Linus Walleij
2026-11-16 14:45 ` netdev-bot+sashiko
2026-11-12 13:30 ` [PATCH net-next v8 08/19] net: ethernet: cortina: Rotate free queue page allocation Linus Walleij
2026-11-12 13:30 ` [PATCH net-next v8 09/19] net: ethernet: cortina: Recycle claimed free queue pages Linus Walleij
2026-11-12 13:30 ` [PATCH net-next v8 10/19] net: ethernet: cortina: Separate RX buffer capacity from free queue size Linus Walleij
2026-11-16 14:45 ` netdev-bot+sashiko
2026-11-12 13:30 ` [PATCH net-next v8 11/19] net: ethernet: cortina: Validate RX fragment lengths Linus Walleij
2026-11-16 14:45 ` netdev-bot+sashiko
2026-11-12 13:30 ` [PATCH net-next v8 12/19] net: ethernet: cortina: Account RX buffer size in truesize Linus Walleij
2026-11-12 13:30 ` [PATCH net-next v8 13/19] net: ethernet: cortina: Release partial RX frames on stop Linus Walleij
2026-11-12 13:30 ` [PATCH net-next v8 14/19] net: ethernet: cortina: Scale Gemini RX queues to system memory Linus Walleij
2026-11-12 13:30 ` [PATCH net-next v8 15/19] net: ethernet: cortina: Serialize TX completion statistics Linus Walleij
2026-11-16 14:45 ` netdev-bot+sashiko
2026-11-12 13:30 ` [PATCH net-next v8 16/19] net: ethernet: cortina: Scope RX statistics updates Linus Walleij
2026-11-12 13:30 ` [PATCH net-next v8 17/19] net: ethernet: cortina: Drain RX coalescing timer on stop Linus Walleij
2026-11-12 13:30 ` [PATCH net-next v8 18/19] net: ethernet: cortina: Reject TX rings smaller than retained pointers Linus Walleij
2026-11-12 13:30 ` [PATCH net-next v8 19/19] net: ethernet: cortina: Fix ethtool statistics reads Linus Walleij
2026-11-16 14:45 ` netdev-bot+sashiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179484034429.3136.3425183655553071974@kernel.org \
--to=netdev-bot+sashiko@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=kuba@kernel.org \
--cc=linusw@kernel.org \
--cc=mhun512@gmail.com \
--cc=mirq-linux@rere.qmqm.pl \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ulli.kroll@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox