From: netdev-bot+sashiko@kernel.org
To: emmaonana18@gmail.com
Cc: kuba@kernel.org, tianyi@cloudflare.com, netdev@vger.kernel.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
bpf@vger.kernel.org, davem@davemloft.net, edumazet@kernel.org,
pabeni@redhat.com, horms@kernel.org, shuah@kernel.org,
ast@kernel.org, daniel@iogearbox.net, hawk@kernel.org,
john.fastabend@gmail.com, sdf@fomichev.me,
skhan@linuxfoundation.org
Subject: Re: [PATCH net v2] selftests: net: veth: propagate channel-check failures to exit status
Date: Mon, 16 Nov 2026 21:50:01 +0000 [thread overview]
Message-ID: <179486580141.3136.15559598598860423821@kernel.org> (raw)
In-Reply-To: <20261115214702.50817-1-emmaonana18@gmail.com>
Thank you for your contribution! Sashiko AI review found 2 potential
issue(s) to consider.
Critical: 0 · High: 1 · Medium: 1 · Low: 0
If you believe none of the issues are legitimate, please reply to each
issue of Medium severity or higher and explain why the AI is wrong.
If any of them are legitimate and you plan to respin, please let patchwork
know by including "pw-bot: cr" as a separate line at the end of your reply
(one such reply per series is enough).
- [High] The fix is incomplete.
- [Medium] Because chk_channels() now sets ret=1, the "setting invalid
channels nr" check at tools/testing/selftests/net/veth.sh:467-468…
--
selftests: net: veth: propagate channel-check failures to exit status
This patch changes chk_channels() in tools/testing/selftests/net/veth.sh
so that it sets ret=1 when the channel counts reported by ethtool do not
match the expected values. A channel mismatch now gives the script a
non-zero exit status.
> diff --git a/tools/testing/selftests/net/veth.sh b/tools/testing/selftests/net/veth.sh
> index 64c2a5a59821d..5c1dbe1516bb4 100755
> --- a/tools/testing/selftests/net/veth.sh
> +++ b/tools/testing/selftests/net/veth.sh
> @@ -130,6 +130,7 @@ chk_channels() {
> echo " ok "
> else
> echo " fail rx:$rx:$cur_rx tx:$tx:$cur_tx combined:n/a:$cur_combined"
> + ret=1
> fi
> }
[Severity: High]
Is this fix complete?
The commit in the Fixes: tag, 1ec2230fc721 ("selftests: net: veth: add
tests for set_channel"), also added three inline channel/XDP checks to
veth.sh. Each of them prints a fail line but never sets ret:
printf "%-60s" "bad setting: XDP with RX nr less than TX"
ip -n $NS_DST link set dev veth$DST xdp object ${BPF_FILE} \
section xdp 2>/dev/null &&\
echo "fail - set operation successful ?!?" || echo " ok "
printf "%-60s" "bad setting: reducing RX nr below peer TX with XDP set"
ip netns exec $NS_DST ethtool -L veth$DST rx 1 2>/dev/null &&\
echo "fail - set operation successful ?!?" || echo " ok "
printf "%-60s" "bad setting: increasing peer TX nr above RX with XDP set"
ip netns exec $NS_SRC ethtool -L veth$SRC tx 3 2>/dev/null &&\
echo "fail - set operation successful ?!?" || echo " ok "
These checks test the queue count limits in drivers/net/veth.c:
veth_xdp_set():
if (dev->real_num_rx_queues < peer->real_num_tx_queues) {
...
err = -ENOSPC;
veth_set_channels():
if (priv->_xdp_prog && peer && ch->rx_count < peer->real_num_tx_queues)
return -EINVAL;
if (peer && peer_priv && peer_priv->_xdp_prog && ch->tx_count > peer->real_num_rx_queues)
return -EINVAL;
Suppose a kernel change lets one of these invalid configurations
through. The script prints "fail - set operation successful ?!?", but it
still reaches exit $ret with ret=0.
The subject says channel-check failures now reach the exit status.
Should these three sites set ret=1 too?
[Severity: Medium]
Now that this sets ret=1, can the "setting invalid channels nr" check
fail the whole script on hosts where nproc is lower than
num_possible_cpus()?
The test gets its CPU count from nproc and treats CPUS + 1 as an invalid
tx count:
readonly CPUS=`nproc`
[ ... ]
ip netns exec $NS_DST ethtool -L veth$DST tx $((CPUS + 1)) 2>/dev/null
chk_channels "setting invalid channels nr" $DST $CUR_RX $CUR_TX
The kernel limit comes from num_possible_cpus() instead:
drivers/net/veth.c:veth_get_num_queues() {
int queues = num_possible_cpus();
...
}
drivers/net/veth.c:veth_get_channels() {
...
channels->max_tx = dev->num_tx_queues;
channels->max_rx = dev->num_rx_queues;
}
ethnl_set_channels() in net/ethtool/channels.c rejects only
tx_count > max_tx, and the ioctl path does the same.
veth_set_channels() has no upper bound check of its own.
On some hosts nproc is lower than num_possible_cpus(). Examples are QEMU
with -smp N,maxcpus=M, firmware that lists hotpluggable CPU slots, or a
process limited by taskset or cpuset. There the ethtool -L call
succeeds, ethtool -l reports tx = CPUS + 1, and chk_channels() takes the
else branch.
Before this patch, that only printed a fail line. With ret=1, the
selftest now fails even though the kernel behaved correctly.
The commit message says:
all chk_channels() call sites expect the check to pass
That doesn't hold for this call site on such hosts. Should the test pick
its out-of-range tx value from the kernel's reported maximum instead of
from nproc?
--
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261115214702.50817-1-emmaonana18%40gmail.com
prev parent reply other threads:[~2026-11-16 21:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-15 21:47 [PATCH net v2] selftests: net: veth: propagate channel-check failures to exit status Omokefe Emmanuel Onanaroghene
2026-11-16 0:45 ` Tianyi Gao
2026-11-16 0:56 ` Hangbin Liu
2026-11-16 8:41 ` [PATCH net v3 0/2] selftests: net: veth: propagate check " Omokefe Emmanuel Onanaroghene
2026-11-16 8:41 ` [PATCH net v3 1/2] selftests: net: veth: propagate channel-check " Omokefe Emmanuel Onanaroghene
2026-11-16 8:41 ` [PATCH net v3 2/2] selftests: net: veth: propagate bad-settings check " Omokefe Emmanuel Onanaroghene
2026-11-16 14:04 ` Tianyi Gao
2026-11-16 13:08 ` [PATCH net v3 0/2] selftests: net: veth: propagate " Tianyi Gao
2026-11-16 21:50 ` netdev-bot+sashiko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179486580141.3136.15559598598860423821@kernel.org \
--to=netdev-bot+sashiko@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=emmaonana18@gmail.com \
--cc=hawk@kernel.org \
--cc=horms@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=tianyi@cloudflare.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox