From: netdev-bot+sashiko@kernel.org
To: liamsmith827@grapheneos.org
Cc: netdev@vger.kernel.org, dsahern@kernel.org, idosch@nvidia.com,
davem@davemloft.net, edumazet@kernel.org, kuba@kernel.org,
pabeni@redhat.com, horms@kernel.org, shuah@kernel.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
liamsmith827@proton.me
Subject: Re: [PATCH net-next v4 2/4] ipv4: restrict on-link fallback to lookup misses
Date: Mon, 16 Nov 2026 22:08:35 +0000 [thread overview]
Message-ID: <179486691560.3136.15548474074992828914@kernel.org> (raw)
In-Reply-To: <20261115215640.18728-3-liamsmith827@grapheneos.org>
Thank you for your contribution! Sashiko AI review found more severe
issue(s) in other patches of this series. This mail is only an FYI, in case
you want to address the nit picks below when you respin.
Low priority / nit picks for your consideration:
- [Low] The commit "ipv4: restrict on-link fallback to lookup misses" is
written up as a bug fix with security impact: "unprivileged Android…
--
ipv4: restrict on-link fallback to lookup misses
This patch changes ip_route_output_key_hash_rcu() so that, for non-vrf
unicast with an oif set, the on-link fallback happens only when
fib_lookup() reports a lookup miss (-ESRCH via FIB_LOOKUP_REPORT_MISS).
Before, it happened for any lookup error. Blackhole, prohibit and
unreachable routes and rules are now honored for oif-bound sends, and
-ESRCH is mapped back to -ENETUNREACH on the error path.
> A specific example of this being a problem is within Android, where the
> VPN "kill switch" is implemented with prohibit rules. Any process that
> can set flowi4_oif (SO_BINDTODEVICE, IP_UNICAST_IF, IP_PKTINFO, etc.) is
> able to utilize this fallback, meaning unprivileged Android apps can
> trivially bypass the VPN. This is particularly bad on cellular networks,
> where ARP is often not needed.
[ ... ]
> Signed-off-by: Liam Smith <liamsmith827@proton.me>
[Severity: Low]
This isn't a code bug, but should the commit carry a Fixes: tag?
The message describes this as a fix for a VPN bypass. The trailer block
only has Signed-off-by. Documentation/process/maintainer-netdev.rst says:
"for fixes the Fixes: tag is required, regardless of the tree"
In ip_route_output_key_hash_rcu(), falling back to on-link for any
fib_lookup() error goes back to:
1da177e4c3f4 ("Linux-2.6.12-rc2")
The baseline form of the condition this patch changes:
(ipv4_is_multicast(fl4->daddr) || !fl4->flowi4_l3mdev)
comes from:
40867d74c374 ("net: Add l3mdev index to flow struct and avoid oif reset for port devices")
Could one of these be named in a Fixes: tag? That would make it clear
whether this change is meant for stable. It also changes what oif-bound
sockets see when they hit reject routes or rules: those sends now return
an error instead of going out on-link.
--
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261115215640.18728-1-liamsmith827%40grapheneos.org
next prev parent reply other threads:[~2026-11-16 22:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-15 21:56 [PATCH net-next v4 0/4] ipv4: restrict on-link fallback to lookup misses liamsmith827
2026-11-15 21:56 ` [PATCH net-next v4 1/4] ipv4: add FIB_LOOKUP_REPORT_MISS liamsmith827
2026-11-15 21:56 ` [PATCH net-next v4 2/4] ipv4: restrict on-link fallback to lookup misses liamsmith827
2026-11-16 22:08 ` netdev-bot+sashiko [this message]
2026-11-15 21:56 ` [PATCH net-next v4 3/4] selftests: net: test restricted on-link fallback liamsmith827
2026-11-16 8:59 ` Ido Schimmel
2026-11-16 20:27 ` liamsmith827
2026-11-16 22:08 ` netdev-bot+sashiko
2026-11-15 21:56 ` [PATCH net-next v4 4/4] ipv4: replace obsolete routing comment liamsmith827
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179486691560.3136.15548474074992828914@kernel.org \
--to=netdev-bot+sashiko@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@kernel.org \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=liamsmith827@grapheneos.org \
--cc=liamsmith827@proton.me \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox