From: netdev-bot+sashiko@kernel.org
To: imv4bel@gmail.com
Cc: dsahern@kernel.org, idosch@nvidia.com, davem@davemloft.net,
edumazet@kernel.org, kuba@kernel.org, pabeni@redhat.com,
horms@kernel.org, richardbgobert@gmail.com, willemb@google.com,
kuniyu@google.com, netdev@vger.kernel.org
Subject: Re: [PATCH net v2] net: gro: avoid truncating transport header offsets
Date: Tue, 17 Nov 2026 13:30:35 +0000 [thread overview]
Message-ID: <179492223500.3136.9448543337352524214@kernel.org> (raw)
In-Reply-To: <avcJ_0-OqgDlD5GB@v4bel>
Thank you for your contribution! Sashiko AI review found 2 potential
issue(s) to consider.
Critical: 0 · High: 1 · Medium: 0 · Low: 1
If you believe none of the issues are legitimate, please reply to each
issue of Medium severity or higher and explain why the AI is wrong.
If any of them are legitimate and you plan to respin, please let patchwork
know by including "pw-bot: cr" as a separate line at the end of your reply
(one such reply per series is enough).
- [High] ipv6: gro: u16 off truncation in ipv6_gro_receive() inflates
data_offset
- [Low] The commit message says the reproducer is already blocked by a
GRO extension-header limit.
--
net: gro: avoid truncating transport header offsets
This patch replaces skb_set_transport_header() with
skb_set_transport_header_careful() in ipv6_gro_receive() and
inet_gro_receive(). If the GRO transport offset does not fit in the
16-bit skb->transport_header, the skb is not held as a new GRO head and
goes through the normal receive path instead.
> The IP6_MAX_EXT_HDRS_CNT limit in ipv6_gro_pull_exthdrs() prevents this
> reproducer. However, nested encapsulations can each add an extension
> header chain, so the accumulated offset can still exceed the range of
> skb->transport_header. inet_gro_receive() can also be reached with such
> an offset.
[Severity: Low]
Is this paragraph accurate for the tree this patch applies to? Here,
ipv6_gro_pull_exthdrs() in net/ipv6/ip6_offload.c is still an unbounded
loop with no header counter:
net/ipv6/ip6_offload.c:ipv6_gro_pull_exthdrs() {
for (;;) {
int len;
ops = rcu_dereference(inet6_offloads[proto]);
if (unlikely(!ops))
break;
if (!(ops->flags & INET6_PROTO_GSO_EXTHDR))
break;
...
}
IP6_MAX_EXT_HDRS_CNT is not referenced anywhere in ip6_offload.c.
The limit appears to come from Eric's prerequisite patch. That patch is
only mentioned in the v2 notes below the --- line, and git am drops those
notes. The permanent log would then describe a cap that is not in this
tree, and nothing would point to the patch that adds it. In this tree,
this change is the only thing that stops the KASAN reproducer.
Could the prerequisite be referenced in the changelog itself, for example
with a Link: tag? Or could the sentence be reworded?
The nested encapsulation argument could also be more specific. With a
12-header cap, one GRO pass handles at most two L3 layers through
encap_mark. That comes to about 2 x 12 x 2048 bytes, roughly 49 KB, plus
a small amount of driver headroom. That total is still below 64 KB.
Which path still exceeds the range? One candidate is a second GRO pass
through gro_cells after decapsulation, where the pulled outer headers
become headroom. Could the changelog name the concrete path?
Also, skb_set_transport_header_careful() was added by commit f12c2de4f542
("batman-adv: reject unrepresentable multicast TVLV offsets"). This patch
carries Fixes: 4b0ebbca3e16 and Cc: stable, so stable trees would need
f12c2de4f542 as well. Should that dependency be noted in the changelog?
[ ... ]
> diff --git a/net/ipv6/ip6_offload.c b/net/ipv6/ip6_offload.c
> --- a/net/ipv6/ip6_offload.c
> +++ b/net/ipv6/ip6_offload.c
> @@ -249,7 +249,8 @@ INDIRECT_CALLABLE_SCOPE struct sk_buff *ipv6_gro_receive(struct list_head *head,
> skb_gro_pull(skb, sizeof(*iph));
> }
>
> - skb_set_transport_header(skb, skb_gro_offset(skb));
> + if (!skb_set_transport_header_careful(skb, skb_gro_offset(skb)))
> + goto out;
>
> NAPI_GRO_CB(skb)->proto = proto;
>
[Severity: High]
Can this early exit turn a truncated inner offset into a heap
overflow?
Suppose outer layers advance skb_gro_offset() to just below the
limit, so the outer transport offset still passes the new careful
check. A tunnel and L2 callback such as gre_gro_receive() followed by
eth_gro_receive() can then pull a few more bytes without any U16_MAX
check. The inner ipv6_gro_receive() is entered with off above 65535.
It stores off into the u16 network_offsets[] slot before anything
validates it, so the slot holds off - 65536.
If the inner nexthdr is an extension header, ipv6_gro_pull_exthdrs()
then does:
net/ipv6/ip6_offload.c:ipv6_gro_pull_exthdrs() {
...
skb_gro_pull(skb, off - skb_gro_receive_network_offset(skb));
...
}
Subtracting the truncated value advances data_offset by an extra
65536. On a linear skb the extension headers were read through
frag0, so frag0_len is still set.
Before this patch, tcp6_gro_receive() or udp6_gro_receive() called
skb_gro_header() with the inflated offset. That went through
skb_gro_header_slow(), which invalidated frag0. With this change the
careful check fails first. We jump to out with data_offset far past
skb_headlen() and frag0_len still non-zero.
dev_gro_receive() then takes the normal path and calls
gro_try_pull_from_frag0(). grow is roughly 64KB and frag0_len is
non-zero, so gro_pull_from_frag0() copies that many bytes to
skb_tail_pointer(skb), past skb->end. That overwrites
skb_shared_info and the memory after the head buffer.
A single linear skb slightly over 64KB is enough to reach this.
virtio_net, veth, tun/tap and loopback can all deliver one. That
includes devices an unprivileged user sets up in a user and network
namespace.
Could the representability check move to the top of
ipv6_gro_receive(), before off is stored in network_offsets[] and
before ipv6_gro_pull_exthdrs() runs? Making ipv6_gro_pull_exthdrs()
pull relative to skb_gro_offset() would avoid the inflation, but the
truncated network_offsets[] entry would still be wrong for any later
user. inet_gro_receive() stores a truncated network_offsets[] entry
the same way, although it does not inflate data_offset.
--
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/avcJ_0-OqgDlD5GB%40v4bel
prev parent reply other threads:[~2026-11-17 13:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 13:00 [PATCH net v2] net: gro: avoid truncating transport header offsets Hyunwoo Kim
2026-11-17 13:30 ` netdev-bot+sashiko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179492223500.3136.9448543337352524214@kernel.org \
--to=netdev-bot+sashiko@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@kernel.org \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=imv4bel@gmail.com \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardbgobert@gmail.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox