From: netdev-bot+sashiko@kernel.org
To: matttbe@kernel.org
Cc: martineau@kernel.org, geliang@kernel.org, davem@davemloft.net,
edumazet@kernel.org, kuba@kernel.org, pabeni@redhat.com,
horms@kernel.org, fw@strlen.de, dmytro@shytyi.net,
netdev@vger.kernel.org, mptcp@lists.linux.dev,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
mason@kernel.org
Subject: Re: [PATCH net 4/7] mptcp: push queued data on passive TFO subflows becoming established
Date: Tue, 17 Nov 2026 22:29:48 +0000 [thread overview]
Message-ID: <179495458816.3136.11667924714644178222@kernel.org> (raw)
In-Reply-To: <20261116-net-mptcp-misc-fixes-7-4-rc4-v1-4-bf7656de653e@kernel.org>
Thank you for your contribution! Sashiko AI review found more severe
issue(s) in other patches of this series. This mail is only an FYI, in case
you want to address the nit picks below when you respin.
Low priority / nit picks for your consideration:
- [Low] The commit message of "mptcp: push queued data on passive TFO
subflows becoming established" describes behaviour that depends on an…
--
mptcp: push queued data on passive TFO subflows becoming established
With TCP Fast Open, data written by an MPTCP server before the third ACK
could stay queued after that ACK, because the ACK carries MP_CAPABLE
without DSS, so ack_update_msk() is never called. This commit makes
check_fully_established() call __mptcp_check_push() when a subflow becomes
fully established on a passive TFO child (syn_fastopen_child), so the data
is pushed at that point.
Closes: https://lore.kernel.org/mptcp/CAFPPu1gU2Y-D+d4i3F0MoNkYK+e1U+=X3qf6QycjfKBw+8snPg@mail.gmail.com/
> Without this patch, and before the
> earlier commit "mptcp: arm the rtx timer if a push leaves data behind",
> this data was not sent:
>
> server-tfo-write-before-3rd-ack.pkt:24: error handling packet: Timed out waiting for packet
>
> Since this earlier commit, this data is sent, but only when the MPTCP
> retransmission timer fires, here after one second, as the tests increase
> its interval:
[Severity: Low]
Which tree is "mptcp: arm the rtx timer if a push leaves data behind" in?
That commit doesn't seem to be present here, either at this commit or at
the end of the series. The following patch, "mptcp: push queued data on
subflows falling back at the handshake", refers to it the same way. Neither
message gives a SHA or a lore link for it.
In net/mptcp/protocol.c, __mptcp_push_pending() still arms the rtx timer
only when data was copied:
net/mptcp/protocol.c:__mptcp_push_pending() {
...
/* Avoid scheduling the rtx timer if no data has been pushed; the timer
* will be updated on positive acks by __mptcp_cleanup_una().
*/
if (copied) {
if (!mptcp_rtx_timer_pending(sk))
mptcp_reset_rtx_timer(sk);
mptcp_check_send_data_fin(sk);
}
}
__mptcp_subflow_push_pending() also arms it only inside its if (copied)
block.
So in this tree, without this patch, the data would hit the "Timed out
waiting for packet" case. It would not be sent late, after the one second
delay.
Could the changelog say where that commit lives, for example with a SHA or
a lore link? That would let stable backporters find the dependency and see
how the two changes are ordered.
--
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261116-net-mptcp-misc-fixes-7-4-rc4-v1-0-bf7656de653e%40kernel.org
next prev parent reply other threads:[~2026-11-17 22:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 22:06 [PATCH net 0/7] mptcp: misc fixes for v7.4-rc4 Matthieu Baerts (NGI0)
2026-11-16 22:06 ` [PATCH net 1/7] mptcp: do not use a raised snd_wnd for the send window Matthieu Baerts (NGI0)
2026-11-16 22:06 ` [PATCH net 2/7] mptcp: push pending data after a sendmsg copy fault Matthieu Baerts (NGI0)
2026-11-17 22:29 ` netdev-bot+sashiko
2026-11-16 22:06 ` [PATCH net 3/7] mptcp: use sk instead of casting msk in check_fully_established() Matthieu Baerts (NGI0)
2026-11-16 22:06 ` [PATCH net 4/7] mptcp: push queued data on passive TFO subflows becoming established Matthieu Baerts (NGI0)
2026-11-17 22:29 ` netdev-bot+sashiko [this message]
2026-11-16 22:06 ` [PATCH net 5/7] mptcp: push queued data on subflows falling back at the handshake Matthieu Baerts (NGI0)
2026-11-17 22:29 ` netdev-bot+sashiko
2026-11-16 22:06 ` [PATCH net 6/7] mptcp: don't send a FIN before the pending data on fallback Matthieu Baerts (NGI0)
2026-11-17 22:29 ` netdev-bot+sashiko
2026-11-16 22:06 ` [PATCH net 7/7] mptcp: fix dummy mapping of overlapping segments Matthieu Baerts (NGI0)
2026-11-17 22:29 ` netdev-bot+sashiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179495458816.3136.11667924714644178222@kernel.org \
--to=netdev-bot+sashiko@kernel.org \
--cc=davem@davemloft.net \
--cc=dmytro@shytyi.net \
--cc=edumazet@kernel.org \
--cc=fw@strlen.de \
--cc=geliang@kernel.org \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martineau@kernel.org \
--cc=mason@kernel.org \
--cc=matttbe@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox