From: netdev-bot+sashiko@kernel.org
To: anthony.l.nguyen@intel.com
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@kernel.org, andrew+netdev@lunn.ch,
netdev@vger.kernel.org, michal.swiatkowski@linux.intel.com,
poros@redhat.com, david.m.ertman@intel.com, pengpeng@iscas.ac.cn,
przemyslaw.kitszel@intel.com, vinicius.gomes@intel.com,
sridhar.samudrala@intel.com, aleksandr.loktionov@intel.com,
horms@kernel.org, alexander.nowlin@intel.com
Subject: Re: [PATCH net 1/6] ice: use global queue index in TC to-queue offload
Date: Tue, 17 Nov 2026 23:54:29 +0000 [thread overview]
Message-ID: <179495966975.3136.12081407702271648578@kernel.org> (raw)
In-Reply-To: <20261113231225.1864810-2-anthony.l.nguyen@intel.com>
Thank you for your contribution! Sashiko AI review found more severe
issue(s) in other patches of this series. This mail is only an FYI, in case
you want to address the nit picks below when you respin.
Low priority / nit picks for your consideration:
- [Low] In commit "ice: use global queue index in TC to-queue offload",
the PF-to-global queue conversion is done only where the value is…
--
ice: use global queue index in TC to-queue offload
The patch changes the queue ID programmed for TC flower to-queue rules
from the PF-relative index to the global index. It does this by adding
hw->func_caps.common_cap.rxq_first_id in ice_add_tc_flower_adv_fltr().
Before this, rules failed on every PF except PF0.
> diff --git a/drivers/net/ethernet/intel/ice/ice_tc_lib.c b/drivers/net/ethernet/intel/ice/ice_tc_lib.c
> index d20357c041273..6f49ecb4165b2 100644
> --- a/drivers/net/ethernet/intel/ice/ice_tc_lib.c
> +++ b/drivers/net/ethernet/intel/ice/ice_tc_lib.c
> @@ -1202,7 +1202,8 @@ ice_add_tc_flower_adv_fltr(struct ice_vsi *vsi,
> break;
> case ICE_FWD_TO_Q:
> /* HW queue number in global space */
> - rule_info.sw_act.fwd_id.q_id = tc_fltr->action.fwd.q.hw_queue;
> + rule_info.sw_act.fwd_id.q_id = tc_fltr->action.fwd.q.hw_queue +
> + hw->func_caps.common_cap.rxq_first_id;
[Severity: Low]
After this change, tc_fltr->action.fwd.q.hw_queue still holds a
PF-relative value. Is the comment on that field in struct
ice_tc_flower_action still accurate?
drivers/net/ethernet/intel/ice/ice_tc_lib.h:
u16 queue; /* forward to queue */
/* To add filter in HW, absolute queue number in global
* space of queues (between 0...N) is needed
*/
u16 hw_queue;
ice_tc_forward_to_queue() still sets it from the PF-relative rxq_map,
which indexes pf->avail_rxqs:
fltr->action.fwd.q.hw_queue = vsi->rxq_map[queue];
Both dev_dbg() calls in ice_add_tc_flower_adv_fltr() that print
"(HW queue %u)" still print tc_fltr->action.fwd.q.hw_queue:
dev_dbg(dev, "add switch rule action to forward to queue:%u (HW queue %u), lkups_cnt:%u\n",
tc_fltr->action.fwd.q.queue,
tc_fltr->action.fwd.q.hw_queue, lkups_cnt);
dev_dbg(dev, "added switch rule (lkups_cnt %u, flags 0x%x), action is forward to queue: %u (HW queue %u) , rid %u, rule_id %u\n",
lkups_cnt, flags, tc_fltr->action.fwd.q.queue,
tc_fltr->action.fwd.q.hw_queue, rule_added.rid,
rule_added.rule_id);
On any PF where rxq_first_id is non-zero, these messages now show a
different queue from the one written into fwd_id.q_id.
Would it make sense to add rxq_first_id where hw_queue is assigned in
ice_tc_forward_to_queue()? That would keep the stored value, the
comment and the debug output matching what is programmed. The other
option is to update the comment and the log labels to say the value is
PF-relative.
> rule_info.sw_act.vsi_handle = dest_vsi->idx;
> rule_info.priority = ICE_SWITCH_FLTR_PRIO_QUEUE;
> rule_info.sw_act.src = hw->pf_id;
--
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261113231225.1864810-1-anthony.l.nguyen%40intel.com
next prev parent reply other threads:[~2026-11-17 23:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 23:12 [PATCH net 0/6][pull request] Intel Wired LAN Driver Updates 2026-11-13 (ice) Tony Nguyen
2026-11-13 23:12 ` [PATCH net 1/6] ice: use global queue index in TC to-queue offload Tony Nguyen
2026-11-17 23:54 ` netdev-bot+sashiko [this message]
2026-11-13 23:12 ` [PATCH net 2/6] ice: skip per-VLAN promisc rules when default VSI Rx rule is set Tony Nguyen
2026-11-17 23:54 ` netdev-bot+sashiko
2026-11-13 23:12 ` [PATCH net 3/6] ice: preserve uplink DFLT Rx rule on switchdev release Tony Nguyen
2026-11-17 23:54 ` netdev-bot+sashiko
2026-11-13 23:12 ` [PATCH net 4/6] ice: Fix incorrect LLDP filter assumptions Tony Nguyen
2026-11-17 23:54 ` netdev-bot+sashiko
2026-11-13 23:12 ` [PATCH net 5/6] ice: propagate ETH56G deskew poll failures Tony Nguyen
2026-11-17 23:54 ` netdev-bot+sashiko
2026-11-13 23:12 ` [PATCH net 6/6] ice: allow reading the last byte of the NVM and Shadow RAM regions Tony Nguyen
2026-11-13 23:18 ` [PATCH net 0/6][pull request] Intel Wired LAN Driver Updates 2026-11-13 (ice) netdev-bot+sinfo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179495966975.3136.12081407702271648578@kernel.org \
--to=netdev-bot+sashiko@kernel.org \
--cc=aleksandr.loktionov@intel.com \
--cc=alexander.nowlin@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=david.m.ertman@intel.com \
--cc=edumazet@kernel.org \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=michal.swiatkowski@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pengpeng@iscas.ac.cn \
--cc=poros@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=sridhar.samudrala@intel.com \
--cc=vinicius.gomes@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox