From: patchwork-bot+netdevbpf@kernel.org
To: Wenbo Sun <sunwenbo@cmss.chinamobile.com>
Cc: davem@davemloft.net, edumazet@kernel.org, kuba@kernel.org,
pabeni@redhat.com, horms@kernel.org, hangbin.liu@linux.dev,
fmancera@suse.de, danishanwar@ti.com, m-karicheri2@ti.com,
wojciech.drewek@intel.com, r-gunasekaran@ti.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
1342116488@qq.com, liuhangbin@kylinos.cn
Subject: Re: [PATCH net v2] net: hsr: clean up synced addresses and allmulti in hsr_del_port()
Date: Thu, 19 Nov 2026 02:10:05 +0000 [thread overview]
Message-ID: <179505420503.2716323.9284279349036950699.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20261112064716.85381-1-sunwenbo@cmss.chinamobile.com>
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Thu, 12 Nov 2026 14:47:16 +0800 you wrote:
> hsr_set_rx_mode() syncs unicast and multicast addresses to slave A and
> slave B devices via dev_uc_sync_multiple() and dev_mc_sync_multiple(),
> and hsr_change_rx_flags() propagates IFF_ALLMULTI via
> dev_set_allmulti().
>
> When an UP HSR device is deleted via hsr_dellink(), hsr_del_ports()
> removes all ports from hsr->ports before unregister_netdevice_queue()
> leads to hsr_dev_close(). Consequently, hsr_dev_close() iterates over an
> already-empty port list and cannot execute dev_uc_unsync() or
> dev_mc_unsync() on the detached slaves. Likewise, when a slave device is
> unregistered while the HSR master is UP, hsr_netdev_notify() calls
> hsr_del_port() directly without running hsr_dev_close(). In addition,
> hsr_dev_close() does not release IFF_ALLMULTI on slave devices either.
> As a result, detached slave devices can retain synced unicast/multicast
> addresses and an elevated allmulti reference count.
>
> [...]
Here is the summary with links:
- [net,v2] net: hsr: clean up synced addresses and allmulti in hsr_del_port()
https://git.kernel.org/netdev/net-next/c/a02d05f6aff8
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2026-11-19 2:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 6:01 [PATCH net] net: hsr: clean up synced addresses and allmulti in hsr_del_port() Wenbo Sun
2026-11-12 0:41 ` Hangbin Liu
2026-11-12 1:05 ` Hangbin Liu
2026-11-12 6:44 ` Wenbo Sun
2026-11-12 9:41 ` Hangbin Liu
2026-11-12 6:47 ` [PATCH net v2] " Wenbo Sun
2026-11-12 9:48 ` Hangbin Liu
2026-11-13 6:06 ` Wenbo Sun
2026-11-13 8:02 ` Hangbin Liu
2026-11-18 13:23 ` Daniel Machon
2026-11-19 2:10 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179505420503.2716323.9284279349036950699.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=1342116488@qq.com \
--cc=danishanwar@ti.com \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=fmancera@suse.de \
--cc=hangbin.liu@linux.dev \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuhangbin@kylinos.cn \
--cc=m-karicheri2@ti.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=r-gunasekaran@ti.com \
--cc=sunwenbo@cmss.chinamobile.com \
--cc=wojciech.drewek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox