Netdev List
 help / color / mirror / Atom feed
From: netdev-bot+sashiko@kernel.org
To: vikas.gupta@broadcom.com
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	bhargava.marreddy@broadcom.com, rahul-rg.gupta@broadcom.com,
	vsrama-krishna.nemani@broadcom.com,
	rajashekar.hudumula@broadcom.com, dharmender.garg@broadcom.com,
	ajit.khaparde@broadcom.com
Subject: Re: [PATCH net-next v8 04/10] bnge: add RXFH ethtool support
Date: Thu, 19 Nov 2026 17:09:06 +0000	[thread overview]
Message-ID: <179510814600.3136.4406095238662565923@kernel.org> (raw)
In-Reply-To: <20261116140653.1685797-5-vikas.gupta@broadcom.com>

Thank you for your contribution! Sashiko AI review found more severe
issue(s) in other patches of this series. This mail is only an FYI, in case
you want to address the nit picks below when you respin.

Low priority / nit picks for your consideration:

- [Low] The commit message does not mention a functional change in
  bnge_alloc_irqs() (drivers/net/ethernet/broadcom/bnge/bnge_resc.c).

--

bnge: add RXFH ethtool support

This patch adds the ethtool RXFH operations (get/set_rxfh and
get/set_rxfh_fields) to bnge. Changes are only accepted while the device
is down. It also moves the default RSS key to netdev_rss_key_fill() and
removes the RSS_HASH_TYPE_DELTA_CAP handling.

> diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_resc.c b/drivers/net/ethernet/broadcom/bnge/bnge_resc.c
> index 506ceee775e19..25aa6e7c43c37 100644
> --- a/drivers/net/ethernet/broadcom/bnge/bnge_resc.c
> +++ b/drivers/net/ethernet/broadcom/bnge/bnge_resc.c

[ ... ]

> @@ -435,12 +435,17 @@ int bnge_alloc_irqs(struct bnge_dev *bd)
>  	 * We dont need to consider NQs as they have been calculated
>  	 * and must be more than irqs_demand.
>  	 */
> +	old_rx = bd->rx_nr_rings;
>  	rc = bnge_adjust_rings(bd, &bd->rx_nr_rings,
>  			       &bd->tx_nr_rings,
>  			       irqs_demand - aux_msix, min == 1);
>  	if (rc)
>  		goto err_free_irqs;
>  
> +	/* The indirection table may point at rings that were just removed */
> +	if (bd->rx_nr_rings != old_rx)
> +		bnge_set_dflt_rss_indir_tbl(bd);
> +

[Severity: Low]
This isn't a bug, but should the commit message mention this change in
bnge_alloc_irqs()?

During probe, bnge_init_one() first calls bnge_net_init_dflt_config(),
which fills the default indirection table from the original rx_nr_rings.
It then calls bnge_alloc_irqs():

bnge_init_one()
    bnge_net_init_dflt_config()   <- table filled from original rx_nr_rings
    bnge_alloc_irqs()
        bnge_adjust_rings()       <- rx_nr_rings may shrink here

Without the new reset, the table could still hold entries for RX rings
that were just removed, and the new get_rxfh would report them before the
first open.

That looks like a fix for a stale-index problem that existed before this
patch. Would it be better as a separate patch, possibly with a Fixes: tag?

The changelog covers the other side changes in detail, such as the new
default key source, the removal of rss_hash_key_valid and the removal of
DELTA_CAP. It does not mention this reset. It also does not mention the
new BNGE_RSS_CAP_IPV6_FLOW_LABEL_RSS_CAP bit or the renumbering of the
BNGE_RSS_CAP_* enum in bnge.h.

>  	tx_cp = bnge_num_tx_to_cp(bd, bd->tx_nr_rings);
>  	bd->nq_nr_rings = (min == 1) ?
>  		max_t(u16, tx_cp, bd->rx_nr_rings) :

-- 
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261116140653.1685797-1-vikas.gupta%40broadcom.com

  reply	other threads:[~2026-11-19 17:09 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 14:06 [PATCH net-next v8 00/10] add features to bnge Vikas Gupta
2026-11-16 14:06 ` [PATCH net-next v8 01/10] bnge: restructure VNIC and filter code Vikas Gupta
2026-11-16 14:06 ` [PATCH net-next v8 02/10] bnge: add NTUPLE/ARFS VNIC Vikas Gupta
2026-11-19 17:09   ` netdev-bot+sashiko
2026-11-16 14:06 ` [PATCH net-next v8 03/10] bnge: add helper functions for multi RSS contexts Vikas Gupta
2026-11-16 14:06 ` [PATCH net-next v8 04/10] bnge: add RXFH ethtool support Vikas Gupta
2026-11-19 17:09   ` netdev-bot+sashiko [this message]
2026-11-16 14:06 ` [PATCH net-next v8 05/10] bnge: add ethtool support to manage RSS contexts Vikas Gupta
2026-11-19 17:09   ` netdev-bot+sashiko
2026-11-16 14:06 ` [PATCH net-next v8 06/10] bnge: remove refcount from L2 filter Vikas Gupta
2026-11-16 14:06 ` [PATCH net-next v8 07/10] bnge: add NTUPLE filter infrastructure Vikas Gupta
2026-11-19 17:09   ` netdev-bot+sashiko
2026-11-16 14:06 ` [PATCH net-next v8 08/10] bnge: add NTUPLE filter support in ethtool Vikas Gupta
2026-11-19 17:09   ` netdev-bot+sashiko
2026-11-16 14:06 ` [PATCH net-next v8 09/10] bnge: add aRFS flow steering ndo support Vikas Gupta
2026-11-19 17:09   ` netdev-bot+sashiko
2026-11-16 14:06 ` [PATCH net-next v8 10/10] bnge: add cpu_rmap support for IRQ affinity Vikas Gupta
2026-11-19 17:09   ` netdev-bot+sashiko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179510814600.3136.4406095238662565923@kernel.org \
    --to=netdev-bot+sashiko@kernel.org \
    --cc=ajit.khaparde@broadcom.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=bhargava.marreddy@broadcom.com \
    --cc=davem@davemloft.net \
    --cc=dharmender.garg@broadcom.com \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=rahul-rg.gupta@broadcom.com \
    --cc=rajashekar.hudumula@broadcom.com \
    --cc=vikas.gupta@broadcom.com \
    --cc=vsrama-krishna.nemani@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox