From: netdev-bot+sashiko@kernel.org
To: stefanomunari.sm@gmail.com
Cc: hkallweit1@gmail.com, nic_swsd@realtek.com,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@kernel.org,
kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v1] r8169: fix RTNL deadlock in runtime suspend
Date: Sat, 21 Nov 2026 01:50:22 +0000 [thread overview]
Message-ID: <179522582267.3135.2912031877143705376@kernel.org> (raw)
In-Reply-To: <20261118000631.17771-1-stefanomunari.sm@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue(s) to consider.
Critical: 0 · High: 0 · Medium: 1 · Low: 0
If you believe none of the issues are legitimate, please reply to each
issue of Medium severity or higher and explain why the AI is wrong.
If any of them are legitimate and you plan to respin, please let patchwork
know by including "pw-bot: cr" as a separate line at the end of your reply
(one such reply per series is enough).
- [Medium] The patch makes rtl8169_runtime_suspend()
(drivers/net/ethernet/realtek/r8169_main.c) return -EBUSY whenever…
--
r8169: fix RTNL deadlock in runtime suspend
This patch replaces rtnl_lock() in rtl8169_runtime_suspend() with
rtnl_trylock(), and returns -EBUSY when RTNL is contended. The goal is to
avoid an ABBA deadlock. The runtime suspend callback keeps the device in
RPM_SUSPENDING while it waits for RTNL. Meanwhile, RTNL holders such as
rtl8169_close() and the ethtool paths wait in pm_runtime_get_sync().
> diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c
> index f151ab6813932..c60d87015eb94 100644
> --- a/drivers/net/ethernet/realtek/r8169_main.c
> +++ b/drivers/net/ethernet/realtek/r8169_main.c
> @@ -5975,7 +5975,14 @@ static int rtl8169_runtime_suspend(struct device *device)
> return 0;
> }
>
> - rtnl_lock();
> + /*
> + * Do not block on RTNL.
> + * Other callers holding RTNL may wait for suspend to complete
> + * in pm_runtime_get_sync(), which would deadlock.
> + */
> + if (!rtnl_trylock())
> + return -EBUSY;
[Severity: Medium]
Once this returns -EBUSY, does anything schedule another runtime suspend
attempt?
r8169 arms the suspend from rtl8169_runtime_idle() with a plain timer
request, not with autosuspend:
drivers/net/ethernet/realtek/r8169_main.c:rtl8169_runtime_idle() {
...
if (!netif_running(tp->dev) || !netif_carrier_ok(tp->dev))
pm_schedule_suspend(device, 10000);
...
}
pm_schedule_suspend() leaves timer_autosuspends at 0. As a result,
pm_suspend_timer_fn() calls rpm_suspend() with RPM_ASYNC but without
RPM_AUTO. The driver also never calls pm_runtime_use_autosuspend() or
pm_runtime_mark_last_busy().
On -EBUSY, the fail path of rpm_suspend() only retries for autosuspend:
drivers/base/power/runtime.c:rpm_suspend() {
...
if (!dev->power.runtime_error && (rpmflags & RPM_AUTO) &&
pm_runtime_autosuspend_expiration(dev) != 0)
goto repeat;
pm_runtime_cancel_pending(dev);
...
}
So the pending request and the suspend timer are both cancelled.
The comment in pci_pm_runtime_suspend() says "-EBUSY and -EAGAIN is used
to request the runtime PM core to schedule a new suspend". The core
doesn't do that for non-autosuspend requests, though.
After that, the suspend is only re-armed if rtl8169_runtime_idle() runs
again. That happens on:
- open/close
- the LED helpers, which use pm_runtime_put_sync()
- the ethtool core's pm_runtime_put() in net/ethtool/ioctl.c and
net/ethtool/netlink.c
- rtl_mac_link_down(), which calls pm_runtime_idle()
rtl8169_get_stats64() uses pm_runtime_put_noidle(), so stats reads don't
re-arm it.
The patch targets a setup where the interface is up with no carrier and
power/control is set to auto. In that setup the link-down event has
already happened.
Suppose an unrelated task holds RTNL when the 10s timer fires. Examples
are a netlink or ethtool request for another NIC, a netdev notifier, or
an ip -s link dump. Can the NIC then stay in D0 indefinitely, without
WAKE_PHY armed? Before this patch, rtnl_lock() waited, so the suspend
always completed.
The commit message says:
If RTNL is held by an unrelated task, the device stays
active until the next idle check (usage count drop or link down).
Is a next idle check actually guaranteed in this setup?
This also looks like the "trylock with fallback to skip the work
entirely" pattern. That pattern is only acceptable when the failure path
reschedules the work.
Would one of these approaches work instead?
- Convert the driver to autosuspend, using pm_runtime_use_autosuspend()
plus pm_runtime_mark_last_busy() before returning -EBUSY, so the PM
core retries.
- Re-arm from the driver after the callback returns, for example with a
work item that calls pm_runtime_idle() or pm_schedule_suspend().
Re-arming from inside the callback won't work, because
pm_runtime_cancel_pending() in the fail path cancels it.
- Restructure the suspend path so it doesn't need RTNL.
> __rtl8169_set_wol(tp, WAKE_PHY);
> rtl8169_net_suspend(tp);
> rtnl_unlock();
--
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261118000631.17771-1-stefanomunari.sm%40gmail.com
prev parent reply other threads:[~2026-11-21 1:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 0:06 [PATCH net v1] r8169: fix RTNL deadlock in runtime suspend Stefano Munari
2026-11-21 1:50 ` netdev-bot+sashiko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179522582267.3135.2912031877143705376@kernel.org \
--to=netdev-bot+sashiko@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=pabeni@redhat.com \
--cc=stefanomunari.sm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox