From: netdev-bot+sashiko@kernel.org
To: sandeeph@loljews.com
Cc: netdev@vger.kernel.org, nbd@nbd.name, lorenzo@kernel.org,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@kernel.org,
kuba@kernel.org, pabeni@redhat.com, matthias.bgg@gmail.com,
angelogioacchino.delregno@collabora.com, linux@armlinux.org.uk,
daniel@makrotopia.org, mason-cw.chang@mediatek.com,
frank-w@public-files.de, linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v7 1/3] net: ethernet: mtk_eth_soc: fix the RX
Date: Sat, 21 Nov 2026 20:21:58 +0000 [thread overview]
Message-ID: <179529251869.3135.16945484998995426880@kernel.org> (raw)
In-Reply-To: <patch-295a65477d87017ff5b65482ffae46fb@loljews.com>
Thank you for your contribution! Sashiko AI review found more severe
issue(s) in other patches of this series. This mail is only an FYI, in case
you want to address the nit picks below when you respin.
Low priority / nit picks for your consideration:
- [Low] The patch subject "net: ethernet: mtk_eth_soc: fix the RX" does
not say what is being fixed and reads like a cut-off sentence.
--
net: ethernet: mtk_eth_soc: fix the RX
This commit resets dma_addr to DMA_MAPPING_ERROR at the start of every
iteration of the mtk_poll_rx() loop. Before this change, a descriptor
that took the release_desc path without a new mapping could be re-armed
with high address bits left over from the previous descriptor. On
MTK_36BIT_DMA SoCs with DRAM above 4 GiB, the hardware would then DMA
to the wrong address.
> net: ethernet: mtk_eth_soc: fix the RX
[Severity: Low]
This isn't a bug, but the subject doesn't say what is being fixed. It
also reads like a sentence that was cut off.
The body describes a specific defect. In mtk_poll_rx(), dma_addr
carries over from the previous loop iteration. A descriptor can reach
release_desc without a new buffer being mapped:
- no netdev for the source port
- MTK_RESETTING is set
- the refill allocation or mapping fails
In those cases rxd2 gets the previous descriptor's high address bits,
while rxd1 still holds the current descriptor's low bits.
None of this shows up in the shortlog, and stable and patchwork tooling
rely on the shortlog. Could the subject be made more descriptive, for
example:
net: ethernet: mtk_eth_soc: reset RX dma_addr for every descriptor
--
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/patch-7d2c457e68de6b53b7348d1bdbeadcec%40loljews.com
next prev parent reply other threads:[~2026-11-21 20:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 19:55 [PATCH net-next v7 0/3] net: ethernet: mtk_eth_soc: 9K jumbo frame support Sandeep Haemoon
2026-11-13 22:34 ` [PATCH net-next v7 1/3] net: ethernet: mtk_eth_soc: fix the RX Sandeep Haemoon
2026-11-21 20:21 ` netdev-bot+sashiko [this message]
2026-11-13 22:34 ` [PATCH net-next v7 2/3] net: ethernet: mtk_eth_soc: skip page_pool Sandeep Haemoon
2026-11-21 20:22 ` netdev-bot+sashiko
2026-11-13 22:40 ` [PATCH net-next v7 3/3] net: ethernet: mtk_eth_soc: add 9K jumbo Sandeep Haemoon
2026-11-21 20:22 ` netdev-bot+sashiko
2026-11-17 19:57 ` [PATCH net-next v7 0/3] net: ethernet: mtk_eth_soc: 9K jumbo frame support netdev-bot+sinfo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179529251869.3135.16945484998995426880@kernel.org \
--to=netdev-bot+sashiko@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=angelogioacchino.delregno@collabora.com \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=frank-w@public-files.de \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=lorenzo@kernel.org \
--cc=mason-cw.chang@mediatek.com \
--cc=matthias.bgg@gmail.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sandeeph@loljews.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox