From: netdev-bot+sashiko@kernel.org
To: kuba@kernel.org
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
michael.chan@broadcom.com, manishc@marvell.com,
joshwash@google.com, hramamurthy@google.com, tariqt@nvidia.com,
saeedm@nvidia.com, daniel@iogearbox.net, hawk@kernel.org,
sdf@fomichev.me, willemb@google.com,
przemyslaw.kitszel@intel.com, bpf@vger.kernel.org
Subject: Re: [PATCH net-next 1/8] net: stop making HW-GRO depend on SW GRO
Date: Sun, 22 Nov 2026 17:03:00 +0000 [thread overview]
Message-ID: <179536698013.3135.16546623491395924004@kernel.org> (raw)
In-Reply-To: <20261118232315.3593731-2-kuba@kernel.org>
Thank you for your contribution! Sashiko AI review found 1 potential
issue(s) to consider.
Critical: 0 · High: 0 · Medium: 1 · Low: 0
If you believe none of the issues are legitimate, please reply to each
issue of Medium severity or higher and explain why the AI is wrong.
If any of them are legitimate and you plan to respin, please let patchwork
know by including "pw-bot: cr" as a separate line at the end of your reply
(one such reply per series is enough).
- [Medium] On bnxt, `ethtool -K $dev gro off lro on` used to give
hardware LRO.
--
net: stop making HW-GRO depend on SW GRO
This patch removes the code in bnxt, qede and bnx2x that cleared
NETIF_F_GRO_HW whenever NETIF_F_GRO was off. The commit message gives
one user visible change: "ethtool -K $dev gro off" no longer implies
"rx-gro-hw off" on these drivers.
[ ... ]
> diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> index 6846a27bfef4c..27c53db2c9e45 100644
> --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> @@ -14092,9 +14092,6 @@ static netdev_features_t bnxt_fix_features(struct net_device *dev,
> if ((bp->flags & BNXT_FLAG_NO_AGG_RINGS) || bp->xdp_prog)
> features &= ~(NETIF_F_LRO | NETIF_F_GRO_HW);
>
> - if (!(features & NETIF_F_GRO))
> - features &= ~NETIF_F_GRO_HW;
> -
> if (features & NETIF_F_GRO_HW)
> features &= ~NETIF_F_LRO;
>
[Severity: Medium]
Does this change what "ethtool -K $dev gro off lro on" does on bnxt?
Before this patch, turning SW GRO off cleared NETIF_F_GRO_HW first. The
LRO request then got past the GRO_HW-over-LRO check below it, and
bnxt_set_features() picked LRO:
bnxt_set_features() {
...
if (features & NETIF_F_GRO_HW)
flags |= BNXT_FLAG_GRO;
else if (features & NETIF_F_LRO)
flags |= BNXT_FLAG_LRO;
...
}
With the check removed, NETIF_F_GRO_HW stays in wanted_features, since
bnxt_init_one() turns it on by default. bnxt_fix_features() then
clears NETIF_F_LRO, and netdev_fix_features() drops it again:
net/core/dev.c:netdev_fix_features() {
...
if ((features & NETIF_F_GRO_HW) && (features & NETIF_F_LRO)) {
netdev_dbg(dev, "Dropping LRO feature since HW-GRO is requested.\n");
features &= ~NETIF_F_LRO;
}
...
}
So the device ends up in BNXT_FLAG_GRO mode instead of BNXT_FLAG_LRO,
and ethtool shows large-receive-offload as "off [requested on]". To get
LRO now, the user also has to set "rx-gro-hw off".
This mapping looks intentional. Before commit 1054aee82321 ("bnxt_en:
Use NETIF_F_GRO_HW."), bnxt_set_features() chose hardware GRO based on
NETIF_F_GRO and fell back to LRO when GRO was off. The GRO -> GRO_HW
dependency kept that behaviour working.
bnx2x_fix_features() checks GRO_HW and LRO in the same order:
if (!bnx2x_mtu_allows_gro(dev->mtu))
features &= ~NETIF_F_GRO_HW;
if (features & NETIF_F_GRO_HW)
features &= ~NETIF_F_LRO;
Fewer users hit this by default, because bnx2x_init_dev() clears
GRO_HW when LRO is on. But if a user has enabled rx-gro-hw and later
runs "gro off lro on", they would also get HW-GRO instead of LRO.
Later patches in the series only remove the bp->xdp_prog clause from
bnxt_fix_features(). The GRO_HW-over-LRO ordering is still there at the
end of the series.
Should the commit message say that LRO requests with gro off are now
refused while rx-gro-hw is on? Or should an explicit LRO request take
precedence here?
--
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261118232315.3593731-1-kuba%40kernel.org
next prev parent reply other threads:[~2026-11-22 17:03 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 23:23 [PATCH net-next 0/8] net: adjust HW GRO and LRO feature handling Jakub Kicinski
2026-11-18 23:23 ` [PATCH net-next 1/8] net: stop making HW-GRO depend on SW GRO Jakub Kicinski
2026-11-22 17:03 ` netdev-bot+sashiko [this message]
2026-11-18 23:23 ` [PATCH net-next 2/8] selftests: drv-net: drop the generic XDP hack from the HW GRO setup Jakub Kicinski
2026-11-19 21:40 ` Willem de Bruijn
2026-11-22 17:03 ` netdev-bot+sashiko
2026-11-18 23:23 ` [PATCH net-next 3/8] net: state the "XDP excludes HW-GRO" rule in the core Jakub Kicinski
2026-11-19 22:59 ` Willem de Bruijn
2026-11-20 22:13 ` Jakub Kicinski
2026-11-22 17:03 ` netdev-bot+sashiko
2026-11-18 23:23 ` [PATCH net-next 4/8] net: state the "XDP excludes LRO" " Jakub Kicinski
2026-11-19 23:02 ` Willem de Bruijn
2026-11-22 17:03 ` netdev-bot+sashiko
2026-11-18 23:23 ` [PATCH net-next 5/8] eth: mlx5e: drop the now-dead HW-GRO and LRO vs XDP handling Jakub Kicinski
2026-11-19 15:42 ` Dragos Tatulea
2026-11-22 17:03 ` netdev-bot+sashiko
2026-11-18 23:23 ` [PATCH net-next 6/8] eth: bnxt_en: don't clear HW-GRO and LRO for XDP in ndo_fix_features Jakub Kicinski
2026-11-18 23:23 ` [PATCH net-next 7/8] eth: qede: drop the now-dead HW-GRO vs XDP handling Jakub Kicinski
2026-11-22 17:03 ` netdev-bot+sashiko
2026-11-18 23:23 ` [PATCH net-next 8/8] eth: gve: drop the now-dead HW-GRO vs XDP interlock Jakub Kicinski
2026-11-18 23:44 ` Ankit Garg
2026-11-19 22:14 ` Harshitha Ramamurthy
2026-11-22 17:03 ` netdev-bot+sashiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179536698013.3135.16546623491395924004@kernel.org \
--to=netdev-bot+sashiko@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=horms@kernel.org \
--cc=hramamurthy@google.com \
--cc=joshwash@google.com \
--cc=kuba@kernel.org \
--cc=manishc@marvell.com \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=saeedm@nvidia.com \
--cc=sdf@fomichev.me \
--cc=tariqt@nvidia.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox