From: Andrew Lunn <andrew@lunn.ch>
To: Maxime Chevallier <maxime.chevallier@bootlin.com>
Cc: davem@davemloft.net, "Jakub Kicinski" <kuba@kernel.org>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Russell King" <linux@armlinux.org.uk>,
"Christophe Leroy" <christophe.leroy@csgroup.eu>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
thomas.petazzoni@bootlin.com, "Simon Horman" <horms@kernel.org>,
"Herve Codina" <herve.codina@bootlin.com>,
"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH net-next v3 04/10] net: freescale: ucc_geth: Fix WOL configuration
Date: Wed, 4 Dec 2024 02:58:54 +0100 [thread overview]
Message-ID: <179742dc-2df2-4d69-99ac-4951dc36aa71@lunn.ch> (raw)
In-Reply-To: <20241203124323.155866-5-maxime.chevallier@bootlin.com>
On Tue, Dec 03, 2024 at 01:43:15PM +0100, Maxime Chevallier wrote:
> The get/set_wol ethtool ops rely on querying the PHY for its WoL
> capabilities, checking for the presence of a PHY and a PHY interrupts
> isn't enough. Address that by cleaning up the WoL configuration
> sequence.
>
> Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
This at least looks sensible.
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
I don't think we are going to get a perfect implementation until we
move most of the logic into phylink. We need the MAC to declare a
bitmap of what WoL options it supports. And we need the PHY to declare
the same. And the core can then figure out which of the enabled WoL
options the PHY should do, which the MAC should do, if the MAC can be
powered off, etc.
But i doubt that will get implemented any time soon.
Andrew
next prev parent reply other threads:[~2024-12-04 1:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-03 12:43 [PATCH net-next v3 00/10] net: freescale: ucc_geth: Phylink conversion Maxime Chevallier
2024-12-03 12:43 ` [PATCH net-next v3 01/10] net: freescale: ucc_geth: Drop support for the "interface" DT property Maxime Chevallier
2024-12-03 12:43 ` [PATCH net-next v3 02/10] net: freescale: ucc_geth: split adjust_link for phylink conversion Maxime Chevallier
2024-12-03 12:43 ` [PATCH net-next v3 03/10] net: freescale: ucc_geth: Use netdev->phydev to access the PHY Maxime Chevallier
2024-12-03 12:43 ` [PATCH net-next v3 04/10] net: freescale: ucc_geth: Fix WOL configuration Maxime Chevallier
2024-12-04 1:58 ` Andrew Lunn [this message]
2024-12-03 12:43 ` [PATCH net-next v3 05/10] net: freescale: ucc_geth: Use the correct type to store WoL opts Maxime Chevallier
2024-12-04 1:59 ` Andrew Lunn
2024-12-03 12:43 ` [PATCH net-next v3 06/10] net: freescale: ucc_geth: Simplify frame length check Maxime Chevallier
2024-12-03 12:43 ` [PATCH net-next v3 07/10] net: freescale: ucc_geth: Hardcode the preamble length to 7 bytes Maxime Chevallier
2024-12-03 12:43 ` [PATCH net-next v3 08/10] net: freescale: ucc_geth: Move the serdes configuration around Maxime Chevallier
2024-12-04 2:12 ` Andrew Lunn
2024-12-03 12:43 ` [PATCH net-next v3 09/10] net: freescale: ucc_geth: Introduce a helper to check Reduced modes Maxime Chevallier
2024-12-04 2:15 ` Andrew Lunn
2024-12-04 8:22 ` Maxime Chevallier
2024-12-04 15:41 ` Andrew Lunn
2024-12-05 7:32 ` Maxime Chevallier
2024-12-03 12:43 ` [PATCH net-next v3 10/10] net: freescale: ucc_geth: phylink conversion Maxime Chevallier
2024-12-06 13:50 ` [PATCH net-next v3 00/10] net: freescale: ucc_geth: Phylink conversion patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179742dc-2df2-4d69-99ac-4951dc36aa71@lunn.ch \
--to=andrew@lunn.ch \
--cc=christophe.leroy@csgroup.eu \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=herve.codina@bootlin.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).