Re: [PATCH] tcp: assign the sock correctly to an outgoing SYNACK packet

David Miller
2013-04-08T21:33:27Z

From: Paul Moore <pmoore@redhat.com>
Date: Mon, 08 Apr 2013 17:24:50 -0400

> If the void pointer is wrapped by a #ifdef (plenty of precedence for that) and
> the management of that pointer is handled by LSM hooks why is it a concern? I
> apologize for pushing on the issue, but I'm having a hard time reconciling the
> reason for the "no" with the comments/decisions about the regression fix; at
> present there seems to be a level of contradiction between the two.

8 bytes times however many millions of packets per second we can process
on a big machine, you do the math.

It's memory, less cache locality, etc. etc. etc.

It's the most important data structure in the entire networking stack,
and every single byte matters.

I want the overhead to be your problem, so that only users of your
stuff eat the overhead, rather than everyone.

And don't even mention ifdefs, that's bogus, because every
distribution turns every option on, %99.9999999 of users will
therefore not see the savings.

Really, this is a dead topic, let's move on.

Thanks.